You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed the IO debounce/throttle tests fail sometimes, seemingly from timing issues. In the Relude_Timer, Relude_Debounce, and Relude_Throttle tests, I tried the Jest.useFakeTimers/Jest.advanceTimerBy (or whatever) API and it seemed to work really nicely, so we should switch these IO tests to use that too.
The text was updated successfully, but these errors were encountered:
Note: I found that when using Jest.useFakeTimers, the Js.Date values are not affected by the spoofed timer changes (which makes sense in hindsight), so we'll have to figure out a different way to run these tests with more deterministic timing, while still testing the timing aspect of them.
I noticed the IO debounce/throttle tests fail sometimes, seemingly from timing issues. In the
Relude_Timer
,Relude_Debounce
, andRelude_Throttle
tests, I tried theJest.useFakeTimers
/Jest.advanceTimerBy
(or whatever) API and it seemed to work really nicely, so we should switch these IO tests to use that too.The text was updated successfully, but these errors were encountered: