How to reach first parent of current node?

[Mirko-Tebaldi]

Question

I have some rows like this

$time_max=strtotime(mysql_result($result,0,'data_max'));

Other like this

$variable_name= call( call ( call ( strtotime(mysql_result($result,0,'data_max')) ) ) );

I'm creating a rule to refactore prev lines as

$date_string = mysql_result($result,0,'data_max');
$time_max=strtotime($date_string);

and

$date_string = mysql_result($result,0,'data_max');
$variable_name= call( call ( call ( strtotime($date_string) ) ) );

To do this I am creating a new node . Then I'd like to use NodesToAddCollector to add new node before the very first node of the current FuncCall I'am parsing.

Can I identifiy the 'first' node? the parent of parent of parent ... node of a current node ?
Is there a method to simply return the "main" node , the 'full node' of 'current line' of code?

[samsonasik]

There is BetterNodeFinder->resolveCurrentStatement() for that, see https://github.com/rectorphp/rector-src/blob/74bb7a0a7153e3b4423dd816da23c5de55875fc2/src/PhpParser/Node/BetterNodeFinder.php#L495

[Mirko-Tebaldi]

How to use this?

It retrieves a use PhpParser\Node\Stmt;
It's not a Node

[samsonasik]

Stmt is a Node, you want the "main" of current Node, which is an Stmt.

If you just want to get parent, you can call `$node->getAttribute(AttributeKey::PARENT);

[samsonasik]

BetterNodeFinder is already inside rule, you can just use it, ref for example usage:

rector/rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php

Line 113 in f913db6

return (bool) $this->betterNodeFinder->findFirstPrevious($namespace, static function (Node $node) : bool {

[Mirko-Tebaldi]

Yes this works. Thanks