prevent re-declare class/interface errors, because of a already loaded php-parser package #5742
Conversation
| require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/ParserFactory.php'; | ||
| require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinter/Standard.php'; | ||
| // prevent re-declare class/interface errors, because of a already loaded php-parser package | ||
| if (!interface_exists('\PhpParser\Node')) { |
There was a problem hiding this comment.
preload.php is generated by composer preload, which should not be manually touched, the command is at:
rector-src/build/build-preload.php
Line 44 in 685ba8a
There was a problem hiding this comment.
ohh my .. another problem is, that because of rector custome patches to nikic/php-parser rector cannot work with a external php-parser version, because the external php-parser will likely not contain the patches rector needs/wants.
IMO rector would need to declare a conflict with any nikic/php-parser as it effectively will not work with another versions loaded at the same time
There was a problem hiding this comment.
yes, I think conflict config can be solution 👍
There was a problem hiding this comment.
or if the issue only in phpunit, then, probably the patch should be in phpunit part itself?
There was a problem hiding this comment.
conflict seems possibly the solution, as there are new nodes that renamed on v5
closes rectorphp/rector#8567