You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to see combinations of date and strtotime like the one in the first diff converted to use Carbon.
Always converting strtotime($invoice->getDate()) to something like Carbon::parse($invoice->getDate())->timestamp seems like a lot of overhead but this might be an idea too.
The same applies to calculations using unix timestamps as can be seen in the second diff.
Please let me know if this makes sense to you.
Feature Request
I'd like to see combinations of
date
andstrtotime
like the one in the first diff converted to use Carbon.Always converting
strtotime($invoice->getDate())
to something likeCarbon::parse($invoice->getDate())->timestamp
seems like a lot of overhead but this might be an idea too.The same applies to calculations using unix timestamps as can be seen in the second diff.
Please let me know if this makes sense to you.
Diff
The text was updated successfully, but these errors were encountered: