Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NarrowPublicClassMethodParamTypeRule: conflicts with explicitly nullable types in PHP 8.4 #39

Open
mbolli opened this issue Aug 8, 2024 · 0 comments

Comments

@mbolli
Copy link

mbolli commented Aug 8, 2024

PHP 8.4 deprecates implicitly nullable types:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Which means to set a default value we have to explicitly allow null or ?type:

public function foo(?bool $dryRun = true) {}

Which could lead to this error:

Parameters should have "bool" types as the only types passed to this method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant