Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate directories in 'lib/datasets' #166

Open
heronshoes opened this issue Mar 31, 2023 · 2 comments
Open

Separate directories in 'lib/datasets' #166

heronshoes opened this issue Mar 31, 2023 · 2 comments

Comments

@heronshoes
Copy link
Contributor

The current lib/datasets directory is a mix of .rb files for the common engine and .rb files for the individual datasets.

I think separating these would improve the outlook.

Proposal 1:

lib/
  datasets/ # includes common/ and each .rb for datasets
    common/

Proposal 2:

lib/
  datasets/ # includes each .rb for datasets
  common/   # includes common engines
@kou
Copy link
Member

kou commented Apr 1, 2023

Proposal 2 isn't acceptable. We should put all files under datasets/ to avoid conflict.

I don't like common. If we use datasets/common/, Datasets::Error should be renamed to Datasets::Common::Error, right?
Datasets::Common::Error is strange for me. I want to use Datasets::Error as an user.

If someone have a proposal, please share it.

@heronshoes
Copy link
Contributor Author

Ah, I didn't think about errors.

Is this work?

lib/
  datasets/ # includes common engines
    (some_good_name)/ # includes each .rb for datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants