You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposal 2 isn't acceptable. We should put all files under datasets/ to avoid conflict.
I don't like common. If we use datasets/common/, Datasets::Error should be renamed to Datasets::Common::Error, right? Datasets::Common::Error is strange for me. I want to use Datasets::Error as an user.
The current
lib/datasets
directory is a mix of .rb files for the common engine and .rb files for the individual datasets.I think separating these would improve the outlook.
Proposal 1:
Proposal 2:
The text was updated successfully, but these errors were encountered: