Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opening non-existent sub directories in URL #41

Open
sinaamini92 opened this issue May 17, 2021 · 4 comments
Open

fix opening non-existent sub directories in URL #41

sinaamini92 opened this issue May 17, 2021 · 4 comments
Assignees
@Qolzam
Labels
bug Something isn't working committed When new fix committed to repository priority:3

Comments

@sinaamini92
Copy link
Collaborator

Describe the bug
entering a random subdirectory after the main URL, opens a profile that doesn't exist

To Reproduce
Steps to reproduce the behavior:

  1. Go to browser's address bar
  2. enter random string after the URL [eg: "social.telar.dev/yahoo.com"]
  3. shows a non-existent profile

Expected behavior
to show 404

Screenshots
Screenshot from 2021-05-17 05-27-09

Desktop:

  • OS: Ubuntu 20.04 LTS
  • Browser: chrome Version 90.0.4430.212 (Official Build) (64-bit)
@sinaamini92 sinaamini92 added the bug Something isn't working label May 17, 2021
@Qolzam Qolzam self-assigned this May 17, 2021
Qolzam added a commit that referenced this issue May 17, 2021
@Qolzam
fix: navigate invalid sub route to not found page #41
40b06ca 
Signed-off-by: Amir Movahedi <[email protected]>
Qolzam added a commit that referenced this issue May 17, 2021
@Qolzam
Merge pull request #43 from red-gold/fixbug/1.0/41
8e53782 
fix: navigate invalid sub route to not found page #41
@Qolzam Qolzam added the committed When new fix committed to repository label May 17, 2021
@Qolzam
Copy link
Member

Qolzam commented May 17, 2021

Dear @sinaamini92 ,

The issue is fixed. Please help me to retest!

Thanks 😊

@Qolzam Qolzam closed this as completed May 21, 2021
@sinaamini92
Copy link
Collaborator Author

@Qolzam it still shows the non-existent route as a profile for a few seconds then redirects to the 404 page

@sinaamini92 sinaamini92 reopened this May 22, 2021
@Qolzam Qolzam mentioned this issue May 23, 2021
Merged
4 tasks
Qolzam added a commit that referenced this issue May 23, 2021
@Qolzam
Merge pull request #49 from red-gold/fixbug/1.0/41
4d5324d 
fix: does not show empty page when profile not exist #41
@Qolzam
Copy link
Member

Qolzam commented May 23, 2021 •
edited
Loading

Dear @sinaamini92
Thank you for checking 🙂 the issue is fixed. Please help me to retest.

@sinaamini92
Copy link
Collaborator Author

that seems to be fixed thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Qolzam Qolzam

Labels
bug Something isn't working committed When new fix committed to repository priority:3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qolzam @sinaamini92