Dockerfile: switch to virtualenv #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing any RPM-packaged Python application will pull Python 3.6 on RHEL8/Streams8 because 3.6 is the system default. This, in turn, will break building the ods-ci container because ods-ci has been using Python 3.7 features since ff7ac1f. virtualenv ( https://virtualenv.pypa.io/en/latest/ ) should be used instead of the venv module to force Python's version to 3.8 instead of the RHEL8/Streams8 default 3.6. Fixes: red-hat-data-services#406 Signed-off-by: François Cami <[email protected]>
|
Reproducers: either:
|
Merged
|
+1 here is a simple reproducer, showing how installing a Python package "breaks" the default mapping of |
jgarciao
added
enhancements
|
Hi @bdattoma @jgarciao @tarukumar could you take a second look please? The above makes ods-ci more robust to system changes. |
|
we couldn't find time and priority for these changes. I'm closing this PR. Thanks for the suggested changes, we might apply them in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing any RPM-packaged Python application will pull Python 3.6
on RHEL8/Streams8 because 3.6 is the system default.
This, in turn, will break building the ods-ci container because ods-ci
has been using Python 3.7 features since ff7ac1f.
virtualenv ( https://virtualenv.pypa.io/en/latest/ ) should be used
instead of the venv module to force Python's version to 3.8 instead
of the RHEL8/Streams8 default 3.6.
Fixes: #406