Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non package index imports #1468

Open
alfonsomthd opened this issue Jul 11, 2024 · 0 comments
Open

Fix non package index imports #1468

alfonsomthd opened this issue Jul 11, 2024 · 0 comments

Comments

@alfonsomthd
Copy link
Collaborator

alfonsomthd commented Jul 11, 2024

https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/upgrade-PatternFly.md#[console-415](https://issues.redhat.com//browse/console-415)

Example of imports to fix:
https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/status/icons.tsx#L2
import { global_danger_color_100 as dangerColor } from '@patternfly/react-tokens/dist/js/global_danger_color_100';

https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/topology/factory/StyleNode.tsx#L6-L8
import { SVGIconProps } from '@patternfly/react-icons/dist/esm/createIcon';

Could be much more such instances across the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant