Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code according to sonar analysis results #244

Open
odockal opened this issue Feb 20, 2019 · 2 comments
Open

Refactor code according to sonar analysis results #244

odockal opened this issue Feb 20, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@odockal
Copy link
Collaborator

odockal commented Feb 20, 2019

I have run a local sonar analysis from sonarlint eclipse plugin and there are some places that could be refactored according to results. It might help to keep codebase clear.

@robstryker
Copy link
Collaborator

This doesn't really seem like an actionable issue, without details of what could be refactored, or why or how?

@odockal
Copy link
Collaborator Author

odockal commented Feb 21, 2019

There is plenty of possible refactoring issues that could be done, listing them here has no meaning as they vary a lot. All are provided by sonar (sonarlint plugin) in IDE. My intentions here are that I will do this issue and implement a couple of PRs one by one that will address always a batch of warning/infos from sonar and let those to be discussed whether are worth enough to be merged. Should not break anything and I will learn code base a bit. @robstryker @jeffmaury wdyt?

@adietish adietish added this to the devex #163 milestone Feb 27, 2019
@adietish adietish self-assigned this Feb 27, 2019
@adietish adietish assigned odockal and unassigned adietish Mar 15, 2019
adietish added a commit to adietish/rsp-server that referenced this issue May 27, 2019
adietish added a commit to adietish/rsp-server that referenced this issue May 27, 2019
adietish added a commit to adietish/rsp-server that referenced this issue May 27, 2019
robstryker pushed a commit that referenced this issue May 28, 2019
Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants