Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ready for review" template not linked #378

Open
sarahbx opened this issue Sep 4, 2023 · 3 comments
Open

"Ready for review" template not linked #378

sarahbx opened this issue Sep 4, 2023 · 3 comments
Assignees

Comments

@sarahbx
Copy link
Contributor

sarahbx commented Sep 4, 2023

Hello,

I did not locate the template in the repo, do you have a link for this?

- Fill the "Ready for review" template so that we can review your PR. This template helps reviewers understand your changes as well as the purpose of your pull request.

Thank you!
Sarah

@grafuls
Copy link
Collaborator

grafuls commented Sep 5, 2023

Thank you for raising this. Looks like we never included it.
Created a new PR with the template which should autopopulate when creating a new PR.

@grafuls grafuls self-assigned this Sep 5, 2023
@sarahbx
Copy link
Contributor Author

sarahbx commented Sep 12, 2023

I believe this needs to be in a different location for it to populate correctly.

currently (in development branch):
.github/ISSUE_TEMPLATE/pull_request_template.md

should be:
.github/PULL_REQUEST_TEMPLATE/pull_request_template.md
or
.github/pull_request_template.md

@grafuls
Copy link
Collaborator

grafuls commented Oct 31, 2023

Thanks for pointing that out, will relocate the file on the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants