Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dom-alikeness? #18

Open
ixti opened this issue Dec 11, 2017 · 3 comments
Open

Better dom-alikeness? #18

ixti opened this issue Dec 11, 2017 · 3 comments

Comments

@ixti
Copy link

ixti commented Dec 11, 2017

I understand that nodom is sort of internal utility belt for re:dom, but I would like to use it for my testing purposes (where I can't use neither phantomjs, nor jsdom). So far all works great and as expected for me except that it has some issues:

  • tagName is lower-cased while according to specs it should be either as is (XML) or upcased (HTML)
  • missing nodeName
  • document does not have childNodes getter.

I'm fine to work on PR, but would like to know if changes like the above are ever have chances to be merged in.

@pakastin
Copy link
Member

Hi!

Go for it, we’re missing contributions! I don’t think there’s a reason for any of those. I will most definitely merge.

@ixti
Copy link
Author

ixti commented Dec 11, 2017

Awesome! Thanks!

@michaelrhodes
Copy link

@ixti Have you seen Raynos/min-document or fgnass/domino? At first glance it seems like the former might work for you, but if not, the latter is more spec-complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants