Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of values in Topic detail if schema has more than one type #190

Closed
chrisjbremner opened this issue Mar 18, 2021 · 4 comments
Closed

Comments

@chrisjbremner
Copy link

I noticed that on the topic detail page, if I have a topic with the following Avro schema:

key1 -> [null, string]
key2 -> string

Then when a message is displayed in the topic detail page, it shows up as:

{
  "key1": {
    "string": "value1"
  },
  "key2": "value2"
}

Ideally, it would display as:

{
  "key1": "value1",
  "key2": "value2"
}

I inspected the messages websocket and confirmed that the message that was displayed came from the backend. I suspect what is returned is simply what Kafka stores internally, but I was wondering if it's possible to strip out these types when deserializing from an Avro schema?

@weeco weeco closed this as completed in 6c47088 Mar 18, 2021
@weeco
Copy link
Contributor

weeco commented Mar 18, 2021

@chrisjbremner I just pushed a commit that potentially fixes this. Could you give it a spin? If this hasn't fixed it I'm afraid I can't do much about it and in that case it might make sense to submit an issue in the repo of the go-avro client maintained by Linkedin.

@chrisjbremner
Copy link
Author

Just tried out kowl:master-06fbeced but looks like the issue still persists. Thanks for giving it a shot, I will submit to go-avro

@chrisjbremner
Copy link
Author

chrisjbremner commented Mar 18, 2021

Oof, go-avro doesn't look like it's actively maintained anymore

@chrisjbremner
Copy link
Author

Looks like someone already made one (linkedin/goavro#167) there's linkedin/goavro#201 that fixes this, but it's been open for a while and hasn't been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants