Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.dockerignore is included in build context hash #117

Open
ethanwu10 opened this issue Feb 13, 2021 · 0 comments · May be fixed by #126
Open

.dockerignore is included in build context hash #117

ethanwu10 opened this issue Feb 13, 2021 · 0 comments · May be fixed by #126
Labels
component/core kind/bug Something isn't working

Comments

@ethanwu10
Copy link
Member

.dockerignore is included in the list of files to hash when hashing the build context, which can lead to unnecessary container rebuilds. Since the only effects of a .dockerignore are to modify what files are included in the build context, which are already captured via evaluation of the rules in the file, the contents of the file add no information (except potentially extraneous information in the form of formatting changes), and thus should not belong in the hash.
@ethanwu10 ethanwu10 added kind/bug Something isn't working component/core labels Feb 13, 2021
ethanwu10 added a commit that referenced this issue Feb 27, 2021
@ethanwu10
fix(docker): exclude .dockerignore from context hash
db0fb48 
Since `.dockerignore` is a means to control what is in the build
context, the contents of the file itself should not be included in the
context hash. See #117 for more details.

Closes #117
@ethanwu10 ethanwu10 linked a pull request Feb 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/core kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docker): exclude .dockerignore from context hash redpwn/rcds
1 participant
@ethanwu10