Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Smart Queue: merging strategy, expose merge function #4

Open
sorodrigo opened this issue Sep 22, 2018 · 1 comment
Open

Smart Queue: merging strategy, expose merge function #4

sorodrigo opened this issue Sep 22, 2018 · 1 comment
Assignees

Comments

@sorodrigo
Copy link
Member

Hello, just want to reboot our smart-queue merging strategy conversation. (Original thread redux-offline/queue#4)

We're almost there! And I feel bad because @prsn @echoes221 have devoted so much time into this and it's still not out there. If I'm right the only remaining issue is the merging strategy, we set to define a merging convention and to expose the merge fn. Right?

@calumpeak
Copy link
Member

The first chance I had to take a look at this was a few days ago. I pushed up a branch and still have a few to-dos on it https://github.com/redux-offline/tools/tree/squashV2?files=1. I fixed a few inconsistencies (there were some immutable issues, adding new items and made the approach a little more declarative, and cleaned up the file into clear separation of concerns).

I'm going to curry the enqueue function so that it can accept a config for merging etc. I need to fix the original merge stategy also. I've gotta go through and fix the tests/add type Def's also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants