Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): example previews workflows #6003

Merged
merged 9 commits into from
May 30, 2024
Merged

Conversation

BatuhanW
Copy link
Member

@BatuhanW BatuhanW commented May 30, 2024

Having preview deployments in a single workflow causes issues. Now they are separated:

  • example-previews-comment.yml to deploy preview deployment with comment.
  • example-previews-dispatch.yml to deploy from GitHub UI.
  • example-previews-pr to deploy on PR.

PR Checklist

Please check if your PR fulfills the following requirements:

What is the current behavior?

Currently all preview deployment jobs are in a single file, causing issues, dispatching example also triggers other example deployments.

What is the new behavior?

All workflows are now separated.

fixes # (issue)

Notes for reviewers

@BatuhanW BatuhanW requested a review from a team as a code owner May 30, 2024 13:02
Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: f2704d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BatuhanW BatuhanW requested a review from aliemir May 30, 2024 14:02
@BatuhanW BatuhanW enabled auto-merge (squash) May 30, 2024 14:02
@BatuhanW BatuhanW merged commit 7620182 into master May 30, 2024
5 of 6 checks passed
@BatuhanW BatuhanW deleted the fix-example-preview-workflow branch May 30, 2024 14:05
BatuhanW added a commit that referenced this pull request Jun 4, 2024
@BatuhanW BatuhanW added this to the June Release milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants