fix(cli): handle errors while fetching dependencies in get-project-type #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35c2ccf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicanerdurmaz
approved these changes
Oct 11, 2024
refine
|
||||||||||||||||||||||||||||||
| Project |
refine
|
| Run status |
|
| Run duration | 27m 00s |
| Commit |
|
| Committer | Ali Emir Şen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
37
|
Skipped
|
0
|
Passing
|
382
|
Tests for review
cypress/e2e/table-material-ui-use-data-grid/all.cy.ts • 1 failed test • table-material-ui-use-data-grid
| Test | Artifacts | |
|---|---|---|
| table-material-ui-use-data-grid > should work with sorter |
Test Replay
Screenshots
|
|
BatuhanW
approved these changes
Oct 11, 2024
This was referenced Oct 14, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
When working with
denoor missingpackage.jsonfile, an error was thrown while determining the project type. This was causing the CLI to crash even though the fallbacks were provided. This PR handles such errors ingetProjectTypeand lets it use the fallback type.fixes #6335