Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… #6432

Conversation

alicanerdurmaz
Copy link
Member

@alicanerdurmaz alicanerdurmaz commented Oct 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

There is no way to pass additional parameters to authProvider from <AuthPage />.

What is the new behavior?

With mutationVariables prop of the <AuthPage /> we are able to send additional parameters to authProvider

fixes #6431

Notes for reviewers

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner October 25, 2024 14:47
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 20916f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@refinedev/chakra-ui Minor
@refinedev/mantine Minor
@refinedev/antd Minor
@refinedev/core Minor
@refinedev/mui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alicanerdurmaz alicanerdurmaz force-pushed the RK-801-auth-page-add-prop-to-pass-extra-params-to-auth-provider branch from 9106f09 to b336066 Compare October 25, 2024 14:52
@alicanerdurmaz alicanerdurmaz changed the title feat(core,antd,mui,mantine,chakra-uş): add new prop to auth-page to p… feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… Oct 25, 2024
@alicanerdurmaz alicanerdurmaz force-pushed the RK-801-auth-page-add-prop-to-pass-extra-params-to-auth-provider branch from b336066 to 317b5e0 Compare October 25, 2024 14:53
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6432 October 25, 2024 15:17 Inactive
Copy link

cypress bot commented Oct 25, 2024

refine    Run #11595

Run Properties:  status check passed Passed #11595  •  git commit ea3f58bb00 ℹ️: Merge 20916f9430f7f8ae230653caa6b386dc9c36f9cd into 7e4144f5659883bb996635cfd44b...
Project refine
Branch Review RK-801-auth-page-add-prop-to-pass-extra-params-to-auth-provider
Run status status check passed Passed #11595
Run duration 19m 08s
Commit git commit ea3f58bb00 ℹ️: Merge 20916f9430f7f8ae230653caa6b386dc9c36f9cd into 7e4144f5659883bb996635cfd44b...
Committer Alican Erdurmaz
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 37
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 383
View all changes introduced in this branch ↗︎

@BatuhanW BatuhanW changed the base branch from master to releases/november October 28, 2024 09:24
@BatuhanW BatuhanW added this to the November Release milestone Oct 28, 2024
@refine-bot refine-bot temporarily deployed to deploy-preview-website-6432 October 28, 2024 10:11 Inactive
@aliemir aliemir merged commit 52d17c9 into releases/november Nov 5, 2024
92 checks passed
@aliemir aliemir deleted the RK-801-auth-page-add-prop-to-pass-extra-params-to-auth-provider branch November 5, 2024 10:12
@BatuhanW BatuhanW mentioned this pull request Nov 7, 2024
BatuhanW pushed a commit that referenced this pull request Nov 7, 2024
- chore(chakra-ui): fix broken tsdoc links #6429 
- feat: export useInvalidateAuthStore hook #6405 Resolves #6341  
- feat(core): add `<MetaContext />` #6435 
- chore(antd): update @ant-design/icons and @ant-design/pro-layout dependencies #6369 Resolves #6363, #5931 
- feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… #6432  Resolves #6431 
- fix(core): link component overrides to instead of go #6462 Resolves #6461 
- fix(react-hook-form): onChange handler autoSave check in useForm #6459 Resolves #6458 
- fix(core): link component ref type is too restrictive (#6464) Resolves #6463
@aliemir aliemir mentioned this pull request Nov 7, 2024
BatuhanW added a commit that referenced this pull request Nov 7, 2024
- chore(chakra-ui): fix broken tsdoc links #6429 
- feat: export useInvalidateAuthStore hook #6405 Resolves #6341  
- feat(core): add `<MetaContext />` #6435 
- chore(antd): update @ant-design/icons and @ant-design/pro-layout dependencies #6369 Resolves #6363, #5931 
- feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… #6432  Resolves #6431 
- fix(core): link component overrides to instead of go #6462 Resolves #6461 
- fix(react-hook-form): onChange handler autoSave check in useForm #6459 Resolves #6458 
- fix(core): link component ref type is too restrictive (#6464) Resolves #6463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] <AuthPage /> should be able to send additional parameters to authProvider methods
4 participants