You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly, we expect vert[0].index to be 0 and vert[1].index to be 1 as NoteLocation indexes the buttons starting at 0. Instead however, we get the following
I also tested the output of the first slide of 神威 which features a slide with multiple segments.
CanReadCompoundSlide.txt
&inote_1=8<6v4[8:3]
test file
it("should be able to read the kamui slide",async()=>{constchartText=awaitfs.readFile(path.join(testChartPath,"./CanReadCompoundSlide.txt"),"utf-8");constsimaiFile=newSimaiFile(chartText);constchart=SimaiConvert.deserialize(simaiFile.getValue("inote_1")!);constsegs=chart.noteCollections[0][0].slidePaths[0].segmentsconsole.log("kamui 0",segs[0])console.log("kamui 1",segs[1])constvert1=segs[0].verticesconstvert2=segs[1].verticesassert.equal(segs.length,2)assert.equal(vert1.length,2)assert.equal(vert1[0].index,6)assert.equal(vert1[1].index,5)assert.equal(vert2.length,2)assert.equal(vert2[0].index,5)assert.equal(vert2[1].index,3)});
The above test did not pass and the 2 console.logs gave
We can also determine that the slide types are correct (2 = RingCcw and 3 = Fold), only the vertices are wrong.
I ran the tests on a fresh copy of the simai.js repo using the existing testing framework present. I have not yet verified whether this issue persists on SimaiSharp. Whenever I get the time, I can take a closer look at solving this issue.
The text was updated successfully, but these errors were encountered:
When parsing a slide, the vertices of the slide path are incorrect.
To reproduce, take the following chart connecting buttons 1 and 2 with a straight slide.
Deserialise the chart contents into
chart
, and use the following to extract the vertices of the single slide path's segments.Firstly, we expect
vert[0].index
to be 0 andvert[1].index
to be 1 asNoteLocation
indexes the buttons starting at 0. Instead however, we get the followingwhich is different from what we were expecting.
I also tested the output of the first slide of 神威 which features a slide with multiple segments.
CanReadCompoundSlide.txt
test file
The above test did not pass and the 2
console.log
s gaveWe can also determine that the slide types are correct (2 = RingCcw and 3 = Fold), only the vertices are wrong.
I ran the tests on a fresh copy of the simai.js repo using the existing testing framework present. I have not yet verified whether this issue persists on SimaiSharp. Whenever I get the time, I can take a closer look at solving this issue.
The text was updated successfully, but these errors were encountered: