Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--css option uses absolute path #187

Open
MisterFruits opened this issue Dec 8, 2018 · 4 comments
Open

--css option uses absolute path #187

MisterFruits opened this issue Dec 8, 2018 · 4 comments

Comments

@MisterFruits
Copy link

Hey I've been fighting with the --css command line option because I thought it would take my CSS and put it in the generated folder. Instead of that if takes the file given in parameter and add a <link rel="stylesheet" href="/absolute/path/style.css" media="all">.

So this implies that moving the folder into a USB key for example will result in not having the extra css right ?

Is it the intended behaviour ?

PS: by the way thanks for this wonderful tool ;)

@regebro
Copy link
Owner

regebro commented Dec 8, 2018

I don't remember if it's intentional that it doesn't get copied in, but if you want that css as a permanent part of the presentation it's better to add it with :css: in the presentation, see for example https://raw.githubusercontent.com/regebro/hovercraft/master/docs/examples/hovercraft.rst

I guess copying it it wouldn't be a problem, so I think this probably should be changed. The only thing I can think of as a potential problem is that it might not be obvious where to copy it.

@MisterFruits
Copy link
Author

I tried with :css: inside the presentation that's indeed working way better ! I'll use it but I was finding the --css really convenient because I allowed me to use the same file without duplicating it for all the presentation that I have in various folders.

Anyway this workaround is very fine for now !
Thanks

@yeyeto2788
Copy link
Collaborator

@MisterFruits, @regebro Hey guys!, correct me if I'm wrong but this issue seems to be related with the #166, right? Can we close the #166 ? It's just for cleaning the issues backlog.

Regards.

P.D: since this is marked as needs investigation that's why I say to close the other one.

@regebro
Copy link
Owner

regebro commented Nov 6, 2019

The issue here is that hovercraft doesn't copy in resources given in absolute paths. I don't want to copy those in, but I don't know why I don't, so I need to think about it more. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants