-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty messages in fetched proposal #9
Comments
Possibly being caused by #8 |
Please add your planning poker estimate with Zenhub @haveanicedavid |
Investigating alongside #33. When fetching proposals, proposal messages are not returned with expected type |
Following up on my initial investigation. The fix would actually happen within telescope and is related to the following issue: |
I can implement a workaround for the time being but we should keep this issue open until the upstream issue is resolved. |
Upstream issue: regen-network/regen-js#71 |
There's currently a bug where messages aren't properly being added to a proposal - they show, but are empty so when an admin goes to execute, things don't behave as expected. Need to make sure all relevant messages are added to a proposal to fix execution
UPDATE - @ryanchristo
The message is included in the proposal on chain but fetching the proposal returns empty messages. The proposal messages were not being parsed correctly:
This is due to an upstream issue in telescope (cosmology-tech/telescope#321) but a workaround was added in #59. This is now dependent upon regen-network/regen-js#71, which is dependent upon cosmology-tech/telescope#321.
The text was updated successfully, but these errors were encountered: