Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty messages in fetched proposal #9

Closed
haveanicedavid opened this issue Mar 28, 2023 · 6 comments
Closed

Fix empty messages in fetched proposal #9

haveanicedavid opened this issue Mar 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@haveanicedavid
Copy link
Contributor

haveanicedavid commented Mar 28, 2023

There's currently a bug where messages aren't properly being added to a proposal - they show, but are empty so when an admin goes to execute, things don't behave as expected. Need to make sure all relevant messages are added to a proposal to fix execution


UPDATE - @ryanchristo

The message is included in the proposal on chain but fetching the proposal returns empty messages. The proposal messages were not being parsed correctly:

messages: [{typeUrl: undefined, value: undefined}]

This is due to an upstream issue in telescope (cosmology-tech/telescope#321) but a workaround was added in #59. This is now dependent upon regen-network/regen-js#71, which is dependent upon cosmology-tech/telescope#321.

@haveanicedavid haveanicedavid added the bug Something isn't working label Mar 28, 2023
@haveanicedavid haveanicedavid self-assigned this Mar 28, 2023
@haveanicedavid
Copy link
Contributor Author

Possibly being caused by #8

@blushi
Copy link
Member

blushi commented Apr 17, 2023

Please add your planning poker estimate with Zenhub @haveanicedavid

@ryanchristo
Copy link
Member

ryanchristo commented May 11, 2023

Investigating alongside #33. When fetching proposals, proposal messages are not returned with expected type SDKAnyType but rather each individual message type. We can implement a workaround but ideally we should resolve in the regen-ts library.

@ryanchristo
Copy link
Member

Following up on my initial investigation. The fix would actually happen within telescope and is related to the following issue:

@ryanchristo
Copy link
Member

I can implement a workaround for the time being but we should keep this issue open until the upstream issue is resolved.

@ryanchristo
Copy link
Member

Upstream issue: regen-network/regen-js#71

ryanchristo added a commit that referenced this issue May 19, 2023
@ryanchristo ryanchristo changed the title Fix empty messages in proposal creation Fix empty messages in fetched proposal May 19, 2023
@ryanchristo ryanchristo reopened this May 22, 2023
@ryanchristo ryanchristo removed their assignment May 22, 2023
@ryanchristo ryanchristo self-assigned this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants