Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sql/ folder #53

Closed
wgwz opened this issue Oct 19, 2023 · 3 comments · Fixed by #58
Closed

Remove sql/ folder #53

wgwz opened this issue Oct 19, 2023 · 3 comments · Fixed by #58
Assignees
Labels
good first issue Good for newcomers

Comments

@wgwz
Copy link
Contributor

wgwz commented Oct 19, 2023

This should have been removed as part of #45. It's just a folder that we were storing old migrations in. These are no longer needed.

@wgwz wgwz added the good first issue Good for newcomers label Oct 19, 2023
@paul121 paul121 self-assigned this Jan 23, 2024
@paul121
Copy link
Contributor

paul121 commented Jan 23, 2024

Note: this sql folder and old migrations are currently used in other places. Before removing here, these other places should be updated to the current graphile-migrate approach for migrations.

I'm still familiarizing myself but noticed sql/run_all_migrations.sh is at least being used in the Docker setup for regen-web: https://github.com/regen-network/regen-web/blob/8789af04941afed2ed582912ff082d7c8ffb9512/docker/scripts/indexer_init.sh#L3-L5

@wgwz
Copy link
Contributor Author

wgwz commented Jan 23, 2024

IIRC I think that is only place we're using it. FWIW - the indexer is pinned to a particular commit with regen-web though - https://github.com/regen-network/regen-web/blob/8789af04941afed2ed582912ff082d7c8ffb9512/docker/indexer.Dockerfile#L8C19-L8C59

Just to say that the regen-web setup wouldn't break immediately upon making this change.

@paul121
Copy link
Contributor

paul121 commented Jan 24, 2024

Thanks @wgwz ! I just opened a PR to update this in regen-web: regen-network/regen-web#2268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants