Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I update the camera externally? #20

Open
wyqydsyq opened this issue Jan 5, 2020 · 0 comments
Open

How do I update the camera externally? #20

wyqydsyq opened this issue Jan 5, 2020 · 0 comments

Comments

@wyqydsyq
Copy link

wyqydsyq commented Jan 5, 2020

As the title says I can't figure out how I'm supposed to update the camera externally from my consuming code. From the README it seems like you're supposed to just mutate properties of the camera function or on the arguments returned in the callback block, but in all my attempts the properties are all mostly undefined and updating them doesn't have any effect.

Looking at the source it seems like this is due to the fact all of these externally exposed properties are being copied by value rather than reference.

I have found a work-around for this by exposing the updateCamera method for external code to call which is available in my fork, but I wanted to know if there's a "correct" way to do this without modifying the library, or is this module intended to be purely internal state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant