Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Origin keys order #17

Closed
Lichtenshtein opened this issue Nov 20, 2023 · 3 comments
Closed

Primary Origin keys order #17

Lichtenshtein opened this issue Nov 20, 2023 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@Lichtenshtein
Copy link

Hi. Сould you please explain the order of writing in the style_primary_origin section in the file music_graph_descriptors_xxx.js? The description says:

// Primary influence. For example one style being the origin of other.
// For ex. 'Rockabilly' and 'Rockabilly revival'.

That means the origin to the left and the influenced sub-genres to the right, right?
Or the primary genres that influenced the genre at the left are the right?
I don't understand some of the entries like this one:

	['Nu-Disco'							,	['Electro','Disco XL','Post-Disco XL']],

This confuses me, because Nu-Disco is a sub-genre from the 21st century.

@regorxxx
Copy link
Owner

It doesn't really matter at all, since the link is bi-directional :)

I mean, you can stick to an specific convention for your own usage, but at the graph, it's just a 'primary influence' and it doesn't care at all about which one "appeared first" or any order.

Also it needs to be bi-directional so you get the influence on both sides when calculating their 'distance'.

To add the date variable, there are currently other ways (like queries, date tag comparison, etc.).

@regorxxx
Copy link
Owner

Planned at some point:

  • A dynamic query -at pre-scoring stage- to do things like: '%DATE% GREATER #CURRENTDATE#'; so you can force tracks with a date greater or lower than the current one (since it's configurable, you could set it to be a decade for ex). You can currently do this, but manually. [universally applicable]
  • A date map. A cultural map was added some releases ago, assigning genres to cultural regions. I plan to do the same by date, so at that point even if the link is bidirectional there will be another set of data telling X appeared before Y, thus X being the origin of Y. Then a filter to output only earlier/later genres would be trivial. [specific for dates]

@regorxxx regorxxx self-assigned this Nov 21, 2023
@regorxxx regorxxx added the question Further information is requested label Nov 21, 2023
@regorxxx regorxxx pinned this issue Nov 21, 2023
@regorxxx regorxxx changed the title Primary Origin Primary Origin keys order Nov 21, 2023
@regorxxx
Copy link
Owner

A dynamic query -at pre-scoring stage- to do things like: '%DATE% GREATER #CURRENTDATE#'; so you can force tracks with a date greater or lower than the current one (since it's configurable, you could set it to be a decade for ex). You can currently do this, but manually. [universally applicable]

This is now implemented here: 1502bbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants