From 58950fb92424462b0c8ba73fb036bb54e5bc1276 Mon Sep 17 00:00:00 2001
From: Mikkel Jakobsen <jakobsen.mikkel@gmail.com>
Date: Fri, 17 May 2024 11:46:55 +0200
Subject: [PATCH] Set branch url in summary

Should work this time
---
 .github/workflows/create-cms-pr.yml                    | 5 +++--
 .github/workflows/create-release-on-branch-changes.yml | 2 --
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/create-cms-pr.yml b/.github/workflows/create-cms-pr.yml
index ca99698e56..925120180b 100644
--- a/.github/workflows/create-cms-pr.yml
+++ b/.github/workflows/create-cms-pr.yml
@@ -17,7 +17,6 @@ jobs:
 
       - name: Set env variables
         run: |
-          echo ${{ toJson(github.repository.html_url) }}
           RELEASE_BRANCH=$(jq -r '.release_branch' release-info.json)
           RELEASE_DOWNLOAD_URL=$(jq -r '.release_download_url' release-info.json)
           DEPENDENCY_PACKAGE=$(jq -r '.dependency_package' release-info.json)
@@ -53,5 +52,7 @@ jobs:
         # TODO: remove hardcoded org/repo
         run: |
           echo "Requested external PR at: reload/poc-dpl-cms-pr-trigger" >> $GITHUB_STEP_SUMMARY
-          echo "Based on the [${{ env.RELEASE_BRANCH }} branch](/tree/${{ env.RELEASE_BRANCH }})" >> $GITHUB_STEP_SUMMARY
+          echo "Based on the [${{ env.RELEASE_BRANCH }}](${{ env.BRANCH_URL }}) branch" >> $GITHUB_STEP_SUMMARY
         if: ${{ steps.invoke_external_pr_workflow.outcome == 'success' }}
+        env:
+          BRANCH_URL: "${{ github.event.repository.html_url }}/tree/${{ env.RELEASE_BRANCH }}"
diff --git a/.github/workflows/create-release-on-branch-changes.yml b/.github/workflows/create-release-on-branch-changes.yml
index 478b44d275..325dd42ae5 100644
--- a/.github/workflows/create-release-on-branch-changes.yml
+++ b/.github/workflows/create-release-on-branch-changes.yml
@@ -19,8 +19,6 @@ jobs:
         # Using branch names as tags allows other projects to track unreleased
         # development.
         run: |
-         echo ${{ toJson(github.event.repository.html_url) }}
-
           RELEASE_BRANCH=$(echo ${GITHUB_REF#refs/heads/})
           RELEASE_BRANCH_SLUGGED=$(echo $RELEASE_BRANCH | sed -E -e 's/[^[:alnum:]]+/-/g' -e 's/^-+|-+$//g' | tr '[:upper:]' '[:lower:]')
           RELEASE_SHA=${{ github.sha }}