You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The readme(s) use the GH permalink https://github.com/DefinitelyTyped/DefinitelyTyped/blob/1253faabf5e0d2c5470db6ea87795d7f96fef7e2/types/history/v2/tsconfig.json in an example. It appears that remark-validate-link (powered by hosted-git-info) recognizes that this is from our GH repo and concludes that the appropriate file to validate is types/history/v2/tsconfig.json, which does not exist.
remark-validate-link doesn't support much configuration, but it seems possible that a .remarkc file could specify its hostname setting to override the inferred value and prevent remark-validate-link from attempting to validate absolute paths as though they were relative. Note, however, that doing so would cause it to miss bad URLs like https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/history/v2/tsconfig.json (which actually doesn't exist). The correct fix would probably require passing a setting to hosted-git-info, possible nocommitish.
The text was updated successfully, but these errors were encountered:
It appears that `remark-validate-link` uses `hosted-git-info` to convert our GH permalink into a relative link (since it shares a prefix with our GH repo) and then warns that the relative link is dangling. This change uses URL encoding to defeat the tool's simple prefix matching.
Filed #58598 to investigate a real solution.
It appears that `remark-validate-link` uses `hosted-git-info` to convert our GH permalink into a relative link (since it shares a prefix with our GH repo) and then warns that the relative link is dangling. This change uses URL encoding to defeat the tool's simple prefix matching.
Filed DefinitelyTyped#58598 to investigate a real solution.
The readme(s) use the GH permalink
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/1253faabf5e0d2c5470db6ea87795d7f96fef7e2/types/history/v2/tsconfig.json
in an example. It appears thatremark-validate-link
(powered byhosted-git-info
) recognizes that this is from our GH repo and concludes that the appropriate file to validate istypes/history/v2/tsconfig.json
, which does not exist.remark-validate-link
doesn't support much configuration, but it seems possible that a.remarkc
file could specify itshostname
setting to override the inferred value and preventremark-validate-link
from attempting to validate absolute paths as though they were relative. Note, however, that doing so would cause it to miss bad URLs likehttps://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/history/v2/tsconfig.json
(which actually doesn't exist). The correct fix would probably require passing a setting tohosted-git-info
, possiblenocommitish
.The text was updated successfully, but these errors were encountered: