-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: selector based dark mode support #16
Comments
I feel like it would be better to solve this with a new rehype plugin, which changes all responsive |
Yep, makes sense. 👍 |
Just realized that this approach would work for |
That’s an interesting point. I’m not really sure how I feel about it. |
Just in case: I do not insist. I see how this can be very specific requirement, which doesn't fit in the project. This was thought out loud |
Hey 👋 . It's me again. I know I proposed previous version of dark mode #6. But here is one more twist to it.
In case of selector based dark mode (so people can select in the dropdown: dark, light, auto) picture doesn't work. See withastro/starlight#1829
Maybe we can add option for selector based dark mode. Generated HTML can look like this:
And CSS for it can look like this:
I know this may be too specific request. Up to your consideration
The text was updated successfully, but these errors were encountered: