Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change react-router to use export maps to remove the server deep import #11643

Open
ryanflorence opened this issue Jun 10, 2024 · 3 comments
Open
Assignees
Labels

Comments

@ryanflorence
Copy link
Member

ryanflorence commented Jun 10, 2024

PR: #11675

We want to keep this working:

import {} from "react-router/server"

But not have to copy the ./dist/server.js file out of dist into the root ./server.js

@markdalgleish
Copy link
Member

markdalgleish commented Jun 17, 2024

I've started looking into this as part of #11646 since I'm moving @react-router/server-runtime to react-router/server (TBD).

@markdalgleish
Copy link
Member

PR: #11675

@jrestall
Copy link

Would you accept a PR to export createRemixRequest and sendRemixResponse from @react-router/express?

These are the only deep imports we use. We use them for our custom express adapter that automatically commits the session cookie as in @sergiodxa's article:

Note: The createRemixRequestHandler, createRemixRequest, handleRequest and sendRemixResponse are all exported from @remix-run/express/dist/server.
https://sergiodxa.com/tutorials/automatically-commit-session-on-remix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants