github-releases datasource does not strip "v" prefix

[neeme-praks-sympower]

Type of discussion.

I'm proposing an idea

Tell us more.

renovate/lib/modules/datasource/github-releases/index.ts

Lines 56 to 64 in 1e6c757

	/**
	* This function can be used to fetch releases with a customizable versioning
	* (e.g. semver) and with releases.
	*
	* This function will:
	* - Fetch all releases
	* - Sanitize the versions if desired (e.g. strip out leading 'v')
	* - Return a dependency object containing sourceUrl string and releases array
	*/

The second point in this list (sanitize) does not seem to be implemented: I just got a PR about ProtoBuf release 22.3 and the version string is v22.3 -- I would expect it to be 22.3. It is possible that this has never worked (as I just recently set up Renovate bot on my project and this is the first PR for updating ProtoBuf).

My bug report was closed and I was directed to open this as discussion topic.

[viceice]

https://docs.renovatebot.com/configuration-options/#extractversion

[neeme-praks-sympower]

Thanks! As a noob, I didn't make the connection from https://docs.renovatebot.com/modules/datasource/github-releases/ to https://docs.renovatebot.com/configuration-options/

[lmagyar]

Could you please help? I've spent 2 days figuring out how github-releases works, none of my configurations work.

Dockerfile:

ARG PORTAINER_VERSION="2.17.1"

New github portainer repo release name: "Release 2.18.1"
New github portainer repo tag: "2.18.1"
See: https://github.com/portainer/portainer/releases

Renovate config:

  "regexManagers": [
    {
      "fileMatch": ["/Dockerfile$"],
      "matchStrings": [
        "ARG PORTAINER_VERSION=[\"']?(?<currentValue>.+?)[\"']?\\s+"
      ],
      "datasourceTemplate": "github-releases",
      "depNameTemplate": "portainer/portainer"
    }
  ]

It has never detected the new version.

I've tried:
Adding "extractVersionTemplate": "^Release (?<version>.*)$" to regexManagers, doesn't work.
Adding

  "packageRules": [
    {
      "matchDatasources": ["github-releases"],
      "matchDepNames": ["portainer/portainer"],
      "extractVersion": "^Release.(?<version>.*)$"
    }
  ]

Or adding

  "packageRules": [
    {
      "matchDatasources": ["github-releases"],
      "matchDepNames": ["portainer/portainer"],
      "versioning": "regex:^Release.(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)?$"
    }
  ]

Still not workig.

I've tried adding a "v" to the dockerfile:

ARG PORTAINER_VERSION="v2.17.1"

Not working.

And nearly all the possible combination of the above, still nothing. It always parses the dockerfile, finds "currentValue": "2.17.1",, but never detects the new release. Never.

[rarkins]

Please start a separate discussion, and create a reproduction repo so we can take a look

[lmagyar]

Thanks, done: #21617