Renovate should not update PLATFORMS during lock file maintenance #21740
Replies: 4 comments
-
Renovate's approach to lock file maintenance is very simple:
So if the old lock file is deleted then There are a few possibilities I can think of to overcome this:
|
Beta Was this translation helpful? Give feedback.
-
I see! Thanks!
|
Beta Was this translation helpful? Give feedback.
-
@rarkins When looking at the code for bundler, I don't see that the Gemfile.lock is actually deleted in However, when perfoming a bundle command like the above (or But that is not the only change - it will also add native gems for that platform, e.g.
(the second entry was already there, the first was added). So we would have to revert both the changes in the PLATFORM-section, AND remove all added gems for the specific platform. Which might mess with the Gemfile, if the dependencies are different for different platforms 😕 The best solution would be if bundle would support an option to prevent adding the platform. However, I don't think this optiion exists at the moment. The responsible code might be these lines When looking at
However, I don't know how the platform gem and bundler are connected, the option does not work for |
Beta Was this translation helpful? Give feedback.
-
Converted to a discussion because without a solution from Bundler, we cannot do anything |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
Mend Renovate hosted app on github.com
If you're self-hosting Renovate, select which platform you are using.
github.com
Was this something which used to work for you, and then stopped?
I never saw this working
Describe the bug
Renovate added
x86_64-linux
in mobile-ios/Gemfile.lock during lock file maintenance.If I understand correctly, because the repo only works in
arm64-darwin
andx86_64-darwin
, it should not addx86_64-linux
in mobile-ios/Gemfile.lock.Here is the minimal reproduction: https://github.com/Hongbo-Miao/bug-renovate-gemfile-lock-platform
Here is the issue pull request: hongbo-miao/bug-renovate-gemfile-lock-platform#2
Thanks! 😃
Relevant debug logs
Logs
Have you created a minimal reproduction repository?
I have linked to a minimal reproduction repository in the bug description
Beta Was this translation helpful? Give feedback.
All reactions