Renovate not filtering out packages for existing PRs when new packageRules config added to renovate.json

[Mknight492]

Type of discussion.

I just want to chat

Tell us more.

I recently came across an issue where I configured Renovate to make all PR with all "minor" and "patch" updates.

This worked as expected, however I also then wanted to filter the PR to only packages which have a major version >1.0.0 so that they were lower risk package updates.

This works as expected for new PR but I don't believe it's working work existing PRs event though the PR summary states it's filtered out the non major version >1.0.0 version.

There's a demonstration repo here.

I first configured renovate to merge all minor and patch packages like so:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "enabled": true,
  "packageRules": [
    {
      "groupName": "All non-major go dependencies",
      "matchUpdateTypes": ["minor", "patch"],
    }
  ]
}

Which raised the correct PR updating the packages like so:

github.com/aws/aws-sdk-go-v2 v1.16.1 -> github.com/aws/aws-sdk-go-v2 v1.18.0
github.com/satori/go.uuid v1.1.0 -> github.com/satori/go.uuid v1.2.0
golang.org/x/tools v0.7.0 -> golang.org/x/tools v0.8.0

However after updating the renovate.json to exclude the package with an unstable API:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "enabled": true,
  "packageRules": [
    {
      "groupName": "All non-major go dependencies",
      "matchUpdateTypes": ["minor", "patch"],
      "matchCurrentVersion": ">=1.0.0"
    }
  ]
}

the PR claims that it's no-longer updating the golang.org/x/tools package

Yet it's still include in the PR here

Is this intended behavior?

Is seems as though it's misleading in the PR summary.

[rarkins]

Does it fix itself if you tick the rebase/retry checkbox?

[Mknight492]

Yes - rebasing or reopening the issue fixes it.

[rarkins]

The issue appears to be this:

• The next time Renovate runs after you modify config, it doesn't "remember" the old config or old PR
• It learns that it needs to have a PR updating two packages, and that such a PR appears to already exist (matching branch name + title)
• It checks if that branch has the required versions it's after - it does
• It (incorrectly) assumes nothing should be done with the branch

The next time it needs to rebase that branch, the problem is fixed.

This can be treated as a bug. Generically, Renovate may not detect when the number of updates in a branch shrinks (it doesn't necessarily need to have anything to do with packageRules)

[Mknight492]

Thanks @rarkins for your very quick response and that makes sense to me. I've raised a Bug here then. I'll wait till it gets reviewed but I'm guessing it wouldn't be a good candidate for first time contributors?

[rarkins]

You are right, it's likely a tricky one to fix