Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Avoiding putting Textmate Scopes in local settings.json #196

Open
multimokia opened this issue Aug 31, 2022 · 2 comments
Open
Labels
backlog Something that is not a priority and will be addressed in a future release enhancement Small improvements topic:syntax

Comments

@multimokia
Copy link
Contributor

Looking at VSCode's Markdown extension, I notice that the same behaviour with highlighting, underlining, italics, and bold etc. are all accomplished without modifying the user's local settings json

Is this possible to accomplish here as well? It'd be great to not have the extension needing to depend on whatever's in the settings json to make some of its richer highlighting features.

@duckdoom4
Copy link
Collaborator

That would be great, so far I've not discovered a way to do this yet. But I can definitely take a look at the markdown extension, to see how that's done.

I do have to note that markdown is most likely added by the theme, and we can't directly modify or add to the current theme. The only way I found, is this round about way of adding custom text mate scopes.

@multimokia
Copy link
Contributor Author

I found this: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#custom-textmate-scope-mappings

It seems to be a way to do what you're doing without modifying a user's settings.
As well, it seems like the extension would likely benefit from a semanticTokenProvider given the existence of a tokenizer (and thus helping to improve python handling)

@duckdoom4 duckdoom4 added backlog Something that is not a priority and will be addressed in a future release and removed suggestion labels Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Something that is not a priority and will be addressed in a future release enhancement Small improvements topic:syntax
Projects
None yet
Development

No branches or pull requests

2 participants