Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False identification of '"$" starts a one-line Python statement' with multi-line say statement #289

Open
Dingotush opened this issue Apr 5, 2023 · 2 comments
Labels
bug Something isn't working topic:diagnostics

Comments

@Dingotush
Copy link

Extension version

2.0.16, 2.1.17

Issue description

A multi-line say statement containing the '$' character, (Note sofia is a character, tip is an integer variable.), such as:

        sofia "Lets see how you made out with tips this evening.
            A very respectable $[tip] you've earned!"

incorrectly reported a warning:
"$" starts a one-line Python statement, but was found in the middle of the line.

In an ideal world this would by identified as a multi-line RenPy say statement, not a Python one, and not flag this as a warning.
If this is not possible, a way to disable this specific warning would be useful.

Note: If the what text containing a $ is on a single line, no warning is reported.

Scope inspector screenshots

multi-line-dollar

Code

    sofia "Lets see how you made out with tips this evening.
        A very respectable $[tip] you've earned!"
@duckdoom4
Copy link
Collaborator

Thanks for the report, that's definitely a bug that should be fixed. It's a bug in the diagnostics section of the extension.
A simple update to the regex to detect strings should do.

@duckdoom4
Copy link
Collaborator

Related to #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:diagnostics
Projects
None yet
Development

No branches or pull requests

2 participants