Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Dies and deadlocks other extensions when loading a big file #437

Open
KuryKat opened this issue Aug 13, 2024 · 5 comments
Open
Labels
bug Something isn't working cannot reproduce

Comments

@KuryKat
Copy link

KuryKat commented Aug 13, 2024

Type: Bug

Open a VERY long renpy script

Extension version: 2.4.0
VS Code version: Code 1.92.1 (eaa41d57266683296de7d118f574d0c2652e1fc4, 2024-08-07T20:16:39.455Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs AMD Ryzen 3 PRO 3200GE w/ Radeon Vega Graphics (4 x 3294)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 15.93GB (8.18GB free)
Process Argv --crash-reporter-id 0237f030-2ee3-4132-9739-3c992f9b889b
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
945dj816:31013170
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31102340
nativerepl2:31104044
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31111718
wkspc-ranged-t:31111713

@duckdoom4 duckdoom4 added bug Something isn't working cannot reproduce labels Aug 15, 2024
@duckdoom4
Copy link
Collaborator

I made it 10x faster (in the next version), but I doubt it will help since I think this issue is caused by it getting stuck somehow

@EtchJetty
Copy link

i have this issue 100% of the time with this extension, when my project is open. is there any way i can help provide anything to help bugfix?

@duckdoom4
Copy link
Collaborator

duckdoom4 commented Aug 23, 2024

@EtchJetty yes please. Any information is welcome at this point.

I think it's related to the open file though, so to confirm, could you tell me if you also have this issue if you open the tutorial project/the question project samples from the renpy SDK?

If you don't have the issue there, it would be really helpful if you could give me more info about the broken project. Best would be to give me a minimum reproducible project, like the file that breaks the extension. You could send it privately if preferred.

If you can't send it due to NDA, then please let me know some generic info about the broken file. How many lines of code are we dealing with? Any chance you could pinpoint the exact code that breaks the extension? Is it any file, or just large files? Can you send the extension logs?

Lastly, it would be awesome if you would be able to run the extension locally (instructions on the main GitHub repo page). If you are able to run it and it gets stuck, you can press the 'pause execution ' button and tell me the part of the codebase that it gets stuck in.

@EtchJetty
Copy link

@duckdoom4 so, since I left that comment I updated to the pre-release version of the extension, and the issue seemingly disappeared???

It tended to only happen with very long files, and especially when I had multiple open. But like I said, after the update the problem hasn't occurred.

I'll return to this thread if it comes back, but if the pre-release version does actually solve this issue incidentally I'm extremely pleased.

(How would I send you the game information privately, btw?)

@duckdoom4
Copy link
Collaborator

duckdoom4 commented Aug 24, 2024

@EtchJetty Ah that's very good news ! Finally fixed this issue then. I've made more changes to the algorithm in 2.5.0, so that's very promising indeed.

I guess it's no longer needed then, but you can send it on discord (duckdoom5#4670)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cannot reproduce
Projects
None yet
Development

No branches or pull requests

3 participants