Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection warnings need to be fixed for native Datahike #632

Open
TimoKramer opened this issue Jul 24, 2023 · 3 comments
Open

Reflection warnings need to be fixed for native Datahike #632

TimoKramer opened this issue Jul 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@TimoKramer
Copy link
Member

Describe the feature you would like to request

There should be no reflection to use Datahike via GraalVM native-compiled binary

Describe the solution you would like

No reflection warnings

Describe alternatives you've considered

none

@TimoKramer TimoKramer added the enhancement New feature or request label Jul 24, 2023
@whilo
Copy link
Member

whilo commented Jun 17, 2024

Some of them have been fixed now, not sure whether all of them are.

@TimoKramer
Copy link
Member Author

TimoKramer commented Jun 19, 2024

I am using this alias for my repl:

   :repl/portal {:extra-deps {nrepl/nrepl {:mvn/version "1.1.0"}
                              cider/cider-nrepl {:mvn/version "0.43.3"}
                              djblue/portal {:mvn/version "0.49.1"}}
                 :jvm-opts ["--enable-preview"]
                 :main-opts ["-e" "(set! *warn-on-reflection* true)"
                             "-m" "nrepl.cmdline"
                             "--middleware" "[cider.nrepl/cider-middleware,portal.nrepl/wrap-portal]"]}}}

We could (set! *warn-on-reflection* true) or #?(:clj (set! *warn-on-reflection* true)) in each namespace to be sure we catch all of it. Or this: https://ask.clojure.org/index.php/3787/theres-enable-warn-reflection-from-command-running-clojure (borkdude's comment)

@whilo
Copy link
Member

whilo commented Jun 23, 2024

A build profile adjustment sounds good, adding a lot of code for it would be not so ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants