New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assoc-in bug #120

Open

pkpkpk opened this issue Sep 4, 2024 · 0 comments

Contributor

pkpkpk commented Sep 4, 2024

this should update nested paths instead of overwriting root value.

Expected behavior should be more akin to:

(defn assoc-in
  [store key-vec val opts]
  (let [[path-vec key] ((juxt pop peek) key-vec)]
    (k/update-in store path-vec #(clojure.core/assoc % key val) opts)))

Simple fix but given its duration should be grouped into a breaking-change release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment