Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference in limit for Int in Int.fromString and Belt.Int.fromString #185

Open
Poornashree08 opened this issue Jan 25, 2024 · 1 comment
Open

Difference in limit for Int in Int.fromString and Belt.Int.fromString #185

Poornashree08 opened this issue Jan 25, 2024 · 1 comment

Comments

@Poornashree08
Copy link

Can see that there was no specific min and max limit check in Belt.Int.fromString but in Rescript core Int.fromString maybeInt > 2147483647 || maybeInt < -2147483648 check is added. Why exactly this limitation was added as this is affecting previous behaviour
Screenshot 2024-01-25 at 6 55 17 PM
?
@seekshiva
Copy link
Contributor

Switching from Belt.Int.toString() to Int.toString() is not seamless here since Belt did not check for these bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seekshiva @Poornashree08