You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Their scope isn't specified explicitly to globalThis.
I also think that the compiler and the Core should not promote specific hosts. window & document are part of the HTML and has nothing to do with Node.js. global is Node.js specific and has nothing to do with browsers.
IMO Core should delegate bindings to third-parties (e.g. rescript-webapi) and keep the representation in JavaScript itself.
The text was updated successfully, but these errors were encountered:
We have this in the
Core
module.(ref: https://github.com/rescript-association/rescript-core/blob/22642ea/src/RescriptCore.res#L47-L49)
However, using
window
anddocument
is not safe becauseJs.globalThis
object binding rescript-compiler#6909 (comment)globalThis
.I also think that the compiler and the Core should not promote specific hosts.
window
&document
are part of the HTML and has nothing to do with Node.js.global
is Node.js specific and has nothing to do with browsers.IMO Core should delegate bindings to third-parties (e.g. rescript-webapi) and keep the representation in JavaScript itself.
The text was updated successfully, but these errors were encountered: