Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support freely configurable suffix for generated .js files #78

Closed
cknitt opened this issue Dec 9, 2023 · 2 comments
Closed

Support freely configurable suffix for generated .js files #78

cknitt opened this issue Dec 9, 2023 · 2 comments
Assignees
@rolandpeelen
Labels
enhancement New feature or request

Comments

@cknitt
Copy link
Member

cknitt commented Dec 9, 2023

Since ReScript 11.0.0-rc.6, the suffix for the generated js files is freely configurable (see rescript-lang/rescript-compiler#6472).

(Well, almost freely, see https://github.com/rescript-lang/rescript-compiler/blob/adb55d016252174237adb5689568ce88032ca2b9/jscomp/bsb/bsb_package_specs.ml#L58.)
@cknitt
Copy link
Member Author

cknitt commented Jan 12, 2024

Given that create-rescript-app and the official installation instructions for v11 are now using .res.(m)js, it would be great to have this fixed.

@rolandpeelen rolandpeelen mentioned this issue Jan 17, 2024
Merged
@rolandpeelen rolandpeelen self-assigned this Jan 17, 2024
@rolandpeelen rolandpeelen added the enhancement New feature or request label Jan 17, 2024
@rolandpeelen
Copy link
Member

Merged in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolandpeelen rolandpeelen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cknitt @rolandpeelen