feat(react-email): Proper error feedback for when there is rate limiting #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmfern
added
App: Preview
Package: react-email
🦋 Changeset detectedLatest commit: 778a6bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
feat/error-feedback-for-test-email-sending
branch
from
ecdf85c to
971aa33
Compare
gabrielmfern
force-pushed
the
canary
branch
3 times, most recently
from
66c5ab9 to
9f5b6d3
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern
force-pushed
the
feat/error-feedback-for-test-email-sending
branch
from
971aa33 to
778a6bb
Compare
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
4ee4d1d to
0187b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the button gets disabled and starts counting down for
15 seconds until it re-enables to attempt sending again. 15 seconds is not
exactly the time it takes, but it should vary dependning on how quickly the
user was able to send the emails that caused the rate limit.
Since the rate limiting here is being enforced by Vercel on our
https://react.email website, Vercel is the one that gives the full HTTP
response to the request when it is rate limited. The problem that this caused
is that the CORS headers were missing in said response, causing the fetch on
the browser to throw a NetworkError and making the response body unaccessible.
The way I went about fixing this temporarily, while we wait for Vercel's
support, was to make the actual fetch to https://react.email inside a server
could actually give the proper treatment to the 429 error code.
action so that the missing CORS headers would not cause a NetworkError and we