slither.db.json

[{"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.isFullyCollateralized() has external calls inside a loop: \"i < trustedBasket.size()\" (contracts/Manager.sol#211)\n", "elements": [{"type": "node", "name": "i < trustedBasket.size()", "source_mapping": {"start": 8000, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [211], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "isFullyCollateralized", "source_mapping": {"start": 7772, "length": 839, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "isFullyCollateralized()"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.isFullyCollateralized() has external calls inside a loop: \"trustedToken = trustedBasket.tokens(i)\" (contracts/Manager.sol#213)\n", "elements": [{"type": "node", "name": "trustedToken = trustedBasket.tokens(i)", "source_mapping": {"start": 8046, "length": 46, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [213], "starting_column": 13, "ending_column": 59}, "type_specific_fields": {"parent": {"type": "function", "name": "isFullyCollateralized", "source_mapping": {"start": 7772, "length": 839, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "isFullyCollateralized()"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.isFullyCollateralized() has external calls inside a loop: \"weight = trustedBasket.weights(trustedToken)\" (contracts/Manager.sol#214)\n", "elements": [{"type": "node", "name": "weight = trustedBasket.weights(trustedToken)", "source_mapping": {"start": 8106, "length": 52, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [214], "starting_column": 13, "ending_column": 65}, "type_specific_fields": {"parent": {"type": "function", "name": "isFullyCollateralized", "source_mapping": {"start": 7772, "length": 839, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "isFullyCollateralized()"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.isFullyCollateralized() has external calls inside a loop: \"balance = IERC20(trustedToken).balanceOf(address(trustedVault))\" (contracts/Manager.sol#215)\n", "elements": [{"type": "node", "name": "balance = IERC20(trustedToken).balanceOf(address(trustedVault))", "source_mapping": {"start": 8193, "length": 71, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [215], "starting_column": 13, "ending_column": 84}, "type_specific_fields": {"parent": {"type": "function", "name": "isFullyCollateralized", "source_mapping": {"start": 7772, "length": 839, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "isFullyCollateralized()"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.isFullyCollateralized() has external calls inside a loop: \"trustedRSV.totalSupply().mul(weight) > balance.mul(scaleFactor)\" (contracts/Manager.sol#218)\n", "elements": [{"type": "node", "name": "trustedRSV.totalSupply().mul(weight) > balance.mul(scaleFactor)", "source_mapping": {"start": 8364, "length": 63, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [218], "starting_column": 17, "ending_column": 80}, "type_specific_fields": {"parent": {"type": "function", "name": "isFullyCollateralized", "source_mapping": {"start": 7772, "length": 839, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "isFullyCollateralized()"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toIssue(uint256) has external calls inside a loop: \"i < trustedBasket.size()\" (contracts/Manager.sol#240)\n", "elements": [{"type": "node", "name": "i < trustedBasket.size()", "source_mapping": {"start": 9377, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [240], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "toIssue", "source_mapping": {"start": 8803, "length": 958, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toIssue(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toIssue(uint256) has external calls inside a loop: \"trustedToken = trustedBasket.tokens(i)\" (contracts/Manager.sol#241)\n", "elements": [{"type": "node", "name": "trustedToken = trustedBasket.tokens(i)", "source_mapping": {"start": 9422, "length": 46, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [241], "starting_column": 13, "ending_column": 59}, "type_specific_fields": {"parent": {"type": "function", "name": "toIssue", "source_mapping": {"start": 8803, "length": 958, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toIssue(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toIssue(uint256) has external calls inside a loop: \"amounts[i] = _weighted(effectiveAmount,trustedBasket.weights(trustedToken),RoundingMode.UP)\" (contracts/Manager.sol#242-246)\n", "elements": [{"type": "node", "name": "amounts[i] = _weighted(effectiveAmount,trustedBasket.weights(trustedToken),RoundingMode.UP)", "source_mapping": {"start": 9482, "length": 157, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [242, 243, 244, 245, 246], "starting_column": 13, "ending_column": 14}, "type_specific_fields": {"parent": {"type": "function", "name": "toIssue", "source_mapping": {"start": 8803, "length": 958, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toIssue(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toRedeem(uint256) has external calls inside a loop: \"i < trustedBasket.size()\" (contracts/Manager.sol#262)\n", "elements": [{"type": "node", "name": "i < trustedBasket.size()", "source_mapping": {"start": 10325, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [262], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "toRedeem", "source_mapping": {"start": 9969, "length": 718, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toRedeem(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toRedeem(uint256) has external calls inside a loop: \"trustedToken = trustedBasket.tokens(i)\" (contracts/Manager.sol#263)\n", "elements": [{"type": "node", "name": "trustedToken = trustedBasket.tokens(i)", "source_mapping": {"start": 10370, "length": 46, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [263], "starting_column": 13, "ending_column": 59}, "type_specific_fields": {"parent": {"type": "function", "name": "toRedeem", "source_mapping": {"start": 9969, "length": 718, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toRedeem(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.toRedeem(uint256) has external calls inside a loop: \"amounts[i] = _weighted(rsvAmount,trustedBasket.weights(trustedToken),RoundingMode.DOWN)\" (contracts/Manager.sol#264-268)\n", "elements": [{"type": "node", "name": "amounts[i] = _weighted(rsvAmount,trustedBasket.weights(trustedToken),RoundingMode.DOWN)", "source_mapping": {"start": 10430, "length": 153, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [264, 265, 266, 267, 268], "starting_column": 13, "ending_column": 14}, "type_specific_fields": {"parent": {"type": "function", "name": "toRedeem", "source_mapping": {"start": 9969, "length": 718, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "toRedeem(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.issue(uint256) has external calls inside a loop: \"i < trustedBasket.size()\" (contracts/Manager.sol#283)\n", "elements": [{"type": "node", "name": "i < trustedBasket.size()", "source_mapping": {"start": 11106, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [283], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "issue", "source_mapping": {"start": 10748, "length": 806, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "issue(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.issue(uint256) has external calls inside a loop: \"IERC20(trustedBasket.tokens(i)).safeTransferFrom(_msgSender(),address(trustedVault),amounts[i])\" (contracts/Manager.sol#284-288)\n", "elements": [{"type": "node", "name": "IERC20(trustedBasket.tokens(i)).safeTransferFrom(_msgSender(),address(trustedVault),amounts[i])", "source_mapping": {"start": 11151, "length": 161, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [284, 285, 286, 287, 288], "starting_column": 13, "ending_column": 14}, "type_specific_fields": {"parent": {"type": "function", "name": "issue", "source_mapping": {"start": 10748, "length": 806, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "issue(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.redeem(uint256) has external calls inside a loop: \"i < trustedBasket.size()\" (contracts/Manager.sol#311)\n", "elements": [{"type": "node", "name": "i < trustedBasket.size()", "source_mapping": {"start": 12091, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [311], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "redeem", "source_mapping": {"start": 11617, "length": 711, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "redeem(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.redeem(uint256) has external calls inside a loop: \"trustedVault.withdrawTo(trustedBasket.tokens(i),amounts[i],_msgSender())\" (contracts/Manager.sol#312)\n", "elements": [{"type": "node", "name": "trustedVault.withdrawTo(trustedBasket.tokens(i),amounts[i],_msgSender())", "source_mapping": {"start": 12136, "length": 74, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [312], "starting_column": 13, "ending_column": 87}, "type_specific_fields": {"parent": {"type": "function", "name": "redeem", "source_mapping": {"start": 11617, "length": 711, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "redeem(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"i < trustedOldBasket.size()\" (contracts/Manager.sol#437)\n", "elements": [{"type": "node", "name": "i < trustedOldBasket.size()", "source_mapping": {"start": 17838, "length": 27, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [437], "starting_column": 26, "ending_column": 53}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"i_scope_0 < trustedBasket.size()\" (contracts/Manager.sol#446)\n", "elements": [{"type": "node", "name": "i_scope_0 < trustedBasket.size()", "source_mapping": {"start": 18184, "length": 24, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [446], "starting_column": 26, "ending_column": 50}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"trustedToken_scope_1 = trustedBasket.tokens(i_scope_0)\" (contracts/Manager.sol#447)\n", "elements": [{"type": "node", "name": "trustedToken_scope_1 = trustedBasket.tokens(i_scope_0)", "source_mapping": {"start": 18229, "length": 46, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [447], "starting_column": 13, "ending_column": 59}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"! trustedOldBasket.has(trustedToken_scope_1)\" (contracts/Manager.sol#448)\n", "elements": [{"type": "node", "name": "! trustedOldBasket.has(trustedToken_scope_1)", "source_mapping": {"start": 18293, "length": 35, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [448], "starting_column": 17, "ending_column": 52}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"_executeBasketShift(trustedOldBasket.weights(trustedToken_scope_1),trustedBasket.weights(trustedToken_scope_1),trustedToken_scope_1,proposer)\" (contracts/Manager.sol#449-454)\n", "elements": [{"type": "node", "name": "_executeBasketShift(trustedOldBasket.weights(trustedToken_scope_1),trustedBasket.weights(trustedToken_scope_1),trustedToken_scope_1,proposer)", "source_mapping": {"start": 18348, "length": 218, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [449, 450, 451, 452, 453, 454], "starting_column": 17, "ending_column": 18}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"trustedToken = trustedOldBasket.tokens(i)\" (contracts/Manager.sol#438)\n", "elements": [{"type": "node", "name": "trustedToken = trustedOldBasket.tokens(i)", "source_mapping": {"start": 17886, "length": 49, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [438], "starting_column": 13, "ending_column": 62}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Manager.executeProposal(uint256) has external calls inside a loop: \"_executeBasketShift(trustedOldBasket.weights(trustedToken),trustedBasket.weights(trustedToken),trustedToken,proposer)\" (contracts/Manager.sol#439-444)\n", "elements": [{"type": "node", "name": "_executeBasketShift(trustedOldBasket.weights(trustedToken),trustedBasket.weights(trustedToken),trustedToken,proposer)", "source_mapping": {"start": 17949, "length": 198, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [439, 440, 441, 442, 443, 444], "starting_column": 13, "ending_column": 14}, "type_specific_fields": {"parent": {"type": "function", "name": "executeProposal", "source_mapping": {"start": 17318, "length": 1460, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19241, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540], "starting_column": 1, "ending_column": 2}}, "signature": "executeProposal(uint256)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "SwapProposal._newBasket(IRSV,Basket) has external calls inside a loop: \"oldWeight = trustedOldBasket.weights(tokens[i])\" (contracts/Proposal.sol#190)\n", "elements": [{"type": "node", "name": "oldWeight = trustedOldBasket.weights(tokens[i])", "source_mapping": {"start": 6823, "length": 55, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [190], "starting_column": 13, "ending_column": 68}, "type_specific_fields": {"parent": {"type": "function", "name": "_newBasket", "source_mapping": {"start": 6368, "length": 1630, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "SwapProposal", "source_mapping": {"start": 5553, "length": 2447, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212], "starting_column": 1, "ending_column": 2}}, "signature": "_newBasket(IRSV,Basket)"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Basket.constructor(Basket,address[],uint256[]) has external calls inside a loop: \"i_scope_0 < trustedPrev.size()\" (contracts/Basket.sol#48)\n", "elements": [{"type": "node", "name": "i_scope_0 < trustedPrev.size()", "source_mapping": {"start": 2345, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [48], "starting_column": 30, "ending_column": 52}, "type_specific_fields": {"parent": {"type": "function", "name": "constructor", "source_mapping": {"start": 1736, "length": 970, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Basket", "source_mapping": {"start": 1048, "length": 1844, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67], "starting_column": 1, "ending_column": 2}}, "signature": "constructor(Basket,address[],uint256[])"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Basket.constructor(Basket,address[],uint256[]) has external calls inside a loop: \"tok = trustedPrev.tokens(i_scope_0)\" (contracts/Basket.sol#49)\n", "elements": [{"type": "node", "name": "tok = trustedPrev.tokens(i_scope_0)", "source_mapping": {"start": 2392, "length": 35, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [49], "starting_column": 17, "ending_column": 52}, "type_specific_fields": {"parent": {"type": "function", "name": "constructor", "source_mapping": {"start": 1736, "length": 970, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Basket", "source_mapping": {"start": 1048, "length": 1844, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67], "starting_column": 1, "ending_column": 2}}, "signature": "constructor(Basket,address[],uint256[])"}}}}]}, {"check": "calls-loop", "impact": "Low", "confidence": "Medium", "description": "Basket.constructor(Basket,address[],uint256[]) has external calls inside a loop: \"weights[tok] = trustedPrev.weights(tok)\" (contracts/Basket.sol#51)\n", "elements": [{"type": "node", "name": "weights[tok] = trustedPrev.weights(tok)", "source_mapping": {"start": 2482, "length": 39, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [51], "starting_column": 21, "ending_column": 60}, "type_specific_fields": {"parent": {"type": "function", "name": "constructor", "source_mapping": {"start": 1736, "length": 970, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Basket", "source_mapping": {"start": 1048, "length": 1844, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67], "starting_column": 1, "ending_column": 2}}, "signature": "constructor(Basket,address[],uint256[])"}}}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/Vault.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Vault.sol", "filename_relative": "contracts/Vault.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Vault.sol", "filename_short": "contracts/Vault.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/test/ReserveV2.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/test/ReserveV2.sol", "filename_relative": "contracts/test/ReserveV2.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/test/ReserveV2.sol", "filename_short": "contracts/test/ReserveV2.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/test/BasicOwnable.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/test/BasicOwnable.sol", "filename_relative": "contracts/test/BasicOwnable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/test/BasicOwnable.sol", "filename_short": "contracts/test/BasicOwnable.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/test/BasicERC20.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/test/BasicERC20.sol", "filename_relative": "contracts/test/BasicERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/test/BasicERC20.sol", "filename_short": "contracts/test/BasicERC20.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/token/ERC20/ERC20.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.totalSupply() (contracts/zeppelin/token/ERC20/IERC20.sol#11) should be declared external\n", "elements": [{"type": "function", "name": "totalSupply", "source_mapping": {"start": 269, "length": 55, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [11], "starting_column": 5, "ending_column": 60}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "totalSupply()"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.totalSupply() (contracts/zeppelin/token/ERC20/ERC20.sol#43-45) should be declared external\n", "elements": [{"type": "function", "name": "totalSupply", "source_mapping": {"start": 1558, "length": 89, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [43, 44, 45], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "totalSupply()"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.balanceOf(address) (contracts/zeppelin/token/ERC20/IERC20.sol#16) should be declared external\n", "elements": [{"type": "function", "name": "balanceOf", "source_mapping": {"start": 407, "length": 68, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [16], "starting_column": 5, "ending_column": 73}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "balanceOf(address)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.balanceOf(address) (contracts/zeppelin/token/ERC20/ERC20.sol#50-52) should be declared external\n", "elements": [{"type": "function", "name": "balanceOf", "source_mapping": {"start": 1705, "length": 108, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [50, 51, 52], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "balanceOf(address)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.transfer(address,uint256) (contracts/zeppelin/token/ERC20/ERC20.sol#62-65) should be declared external\n", "elements": [{"type": "function", "name": "transfer", "source_mapping": {"start": 2016, "length": 155, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [62, 63, 64, 65], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "transfer(address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.transfer(address,uint256) (contracts/zeppelin/token/ERC20/IERC20.sol#25) should be declared external\n", "elements": [{"type": "function", "name": "transfer", "source_mapping": {"start": 695, "length": 77, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [25], "starting_column": 5, "ending_column": 82}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "transfer(address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.allowance(address,address) (contracts/zeppelin/token/ERC20/ERC20.sol#70-72) should be declared external\n", "elements": [{"type": "function", "name": "allowance", "source_mapping": {"start": 2229, "length": 132, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [70, 71, 72], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "allowance(address,address)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.allowance(address,address) (contracts/zeppelin/token/ERC20/IERC20.sol#34) should be declared external\n", "elements": [{"type": "function", "name": "allowance", "source_mapping": {"start": 1047, "length": 83, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [34], "starting_column": 5, "ending_column": 88}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "allowance(address,address)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.approve(address,uint256) (contracts/zeppelin/token/ERC20/ERC20.sol#81-84) should be declared external\n", "elements": [{"type": "function", "name": "approve", "source_mapping": {"start": 2499, "length": 149, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [81, 82, 83, 84], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "approve(address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.approve(address,uint256) (contracts/zeppelin/token/ERC20/IERC20.sol#50) should be declared external\n", "elements": [{"type": "function", "name": "approve", "source_mapping": {"start": 1783, "length": 74, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [50], "starting_column": 5, "ending_column": 79}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "approve(address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "IERC20.transferFrom(address,address,uint256) (contracts/zeppelin/token/ERC20/IERC20.sol#61) should be declared external\n", "elements": [{"type": "function", "name": "transferFrom", "source_mapping": {"start": 2164, "length": 97, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [61], "starting_column": 5, "ending_column": 102}, "type_specific_fields": {"parent": {"type": "contract", "name": "IERC20", "source_mapping": {"start": 175, "length": 2566, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76], "starting_column": 1, "ending_column": 2}}, "signature": "transferFrom(address,address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.transferFrom(address,address,uint256) (contracts/zeppelin/token/ERC20/ERC20.sol#98-102) should be declared external\n", "elements": [{"type": "function", "name": "transferFrom", "source_mapping": {"start": 3106, "length": 300, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [98, 99, 100, 101, 102], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "transferFrom(address,address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.increaseAllowance(address,uint256) (contracts/zeppelin/token/ERC20/ERC20.sol#116-119) should be declared external\n", "elements": [{"type": "function", "name": "increaseAllowance", "source_mapping": {"start": 3801, "length": 207, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [116, 117, 118, 119], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "increaseAllowance(address,uint256)"}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "ERC20.decreaseAllowance(address,uint256) (contracts/zeppelin/token/ERC20/ERC20.sol#135-138) should be declared external\n", "elements": [{"type": "function", "name": "decreaseAllowance", "source_mapping": {"start": 4495, "length": 258, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [135, 136, 137, 138], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "ERC20", "source_mapping": {"start": 1267, "length": 6823, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/ERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/ERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/ERC20.sol", "is_dependency": false, "lines": [31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230], "starting_column": 1, "ending_column": 2}}, "signature": "decreaseAllowance(address,uint256)"}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/rsv/Reserve.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/Reserve.sol", "filename_relative": "contracts/rsv/Reserve.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/Reserve.sol", "filename_short": "contracts/rsv/Reserve.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/rsv/ReserveEternalStorage.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/ReserveEternalStorage.sol", "filename_relative": "contracts/rsv/ReserveEternalStorage.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/ReserveEternalStorage.sol", "filename_short": "contracts/rsv/ReserveEternalStorage.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "external-function", "impact": "Optimization", "confidence": "High", "description": "Ownable.owner() (contracts/ownership/Ownable.sol#34-36) should be declared external\n", "elements": [{"type": "function", "name": "owner", "source_mapping": {"start": 1149, "length": 77, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [34, 35, 36], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Ownable", "source_mapping": {"start": 543, "length": 1946, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78], "starting_column": 1, "ending_column": 2}}, "signature": "owner()"}}]}, {"check": "assembly", "impact": "Informational", "confidence": "High", "description": "Address.isContract(address) uses assembly (contracts/zeppelin/utils/Address.sol#19-32)\n\t- contracts/zeppelin/utils/Address.sol#30-31\n", "elements": [{"type": "function", "name": "isContract", "source_mapping": {"start": 559, "length": 797, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Address", "source_mapping": {"start": 95, "length": 1709, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44], "starting_column": 1, "ending_column": 2}}, "signature": "isContract(address)"}}, {"type": "node", "name": "", "source_mapping": {"start": 1244, "length": 60, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [30, 31], "starting_column": 9, "ending_column": 15}, "type_specific_fields": {"parent": {"type": "function", "name": "isContract", "source_mapping": {"start": 559, "length": 797, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Address", "source_mapping": {"start": 95, "length": 1709, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44], "starting_column": 1, "ending_column": 2}}, "signature": "isContract(address)"}}}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/Manager.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/Proposal.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/ownership/Ownable.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/rsv/IRSV.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/IRSV.sol", "filename_relative": "contracts/rsv/IRSV.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/rsv/IRSV.sol", "filename_short": "contracts/rsv/IRSV.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/GSN/Context.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/GSN/Context.sol", "filename_relative": "contracts/zeppelin/GSN/Context.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/GSN/Context.sol", "filename_short": "contracts/zeppelin/GSN/Context.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/math/SafeMath.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/math/SafeMath.sol", "filename_relative": "contracts/zeppelin/math/SafeMath.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/math/SafeMath.sol", "filename_short": "contracts/zeppelin/math/SafeMath.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/token/ERC20/IERC20.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/IERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/IERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/IERC20.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/token/ERC20/SafeERC20.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/zeppelin/utils/Address.sol#2)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 3, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [2], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_operator' of _operator (contracts/Manager.sol#182) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_operator", "source_mapping": {"start": 6938, "length": 17, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [182], "starting_column": 26, "ending_column": 43}, "type_specific_fields": {"parent": {"type": "function", "name": "setOperator", "source_mapping": {"start": 6917, "length": 147, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [182, 183, 184, 185], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19208, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538], "starting_column": 1, "ending_column": 2}}, "signature": "setOperator(address)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_seigniorage' of _seigniorage (contracts/Manager.sol#188) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_seigniorage", "source_mapping": {"start": 7131, "length": 20, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [188], "starting_column": 29, "ending_column": 49}, "type_specific_fields": {"parent": {"type": "function", "name": "setSeigniorage", "source_mapping": {"start": 7107, "length": 168, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [188, 189, 190, 191], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19208, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538], "starting_column": 1, "ending_column": 2}}, "signature": "setSeigniorage(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_delay' of _delay (contracts/Manager.sol#194) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_delay", "source_mapping": {"start": 7340, "length": 14, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [194], "starting_column": 23, "ending_column": 37}, "type_specific_fields": {"parent": {"type": "function", "name": "setDelay", "source_mapping": {"start": 7322, "length": 126, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [194, 195, 196, 197], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2712, "length": 19208, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538], "starting_column": 1, "ending_column": 2}}, "signature": "setDelay(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_time' of _time (contracts/Proposal.sol#90) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_time", "source_mapping": {"start": 2991, "length": 13, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [90], "starting_column": 21, "ending_column": 34}, "type_specific_fields": {"parent": {"type": "function", "name": "accept", "source_mapping": {"start": 2975, "length": 224, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [90, 91, 92, 93, 94, 95], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Proposal", "source_mapping": {"start": 2244, "length": 1926, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121], "starting_column": 1, "ending_column": 2}}, "signature": "accept(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Variable 'Ownable._nominatedOwner' (contracts/ownership/Ownable.sol#17) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_nominatedOwner", "source_mapping": {"start": 605, "length": 30, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [17], "starting_column": 5, "ending_column": 35}, "type_specific_fields": {"parent": {"type": "contract", "name": "Ownable", "source_mapping": {"start": 543, "length": 1946, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78], "starting_column": 1, "ending_column": 2}}}, "additional_fields": {"target": "variable", "convention": "mixedCase"}}]}, {"check": "solc-version", "impact": "Informational", "confidence": "High", "description": "Pragma version \"0.5.7\" necessitates versions too recent to be trusted. Consider deploying with 0.5.3 (contracts/Basket.sol#1)\n", "elements": [{"type": "pragma", "name": "0.5.7", "source_mapping": {"start": 0, "length": 22, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_relative": "contracts/Basket.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Basket.sol", "filename_short": "contracts/Basket.sol", "is_dependency": false, "lines": [1], "starting_column": 1, "ending_column": 23}, "type_specific_fields": {"directive": ["solidity", "0.5", ".7"]}}]}, {"check": "assembly", "impact": "Informational", "confidence": "High", "description": "Address.isContract(address) uses assembly (contracts/zeppelin/utils/Address.sol#19-32)\n\t- contracts/zeppelin/utils/Address.sol#30\n", "elements": [{"type": "function", "name": "isContract", "source_mapping": {"start": 560, "length": 797, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Address", "source_mapping": {"start": 96, "length": 1709, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44], "starting_column": 1, "ending_column": 2}}, "signature": "isContract(address)"}}, {"type": "node", "name": "", "source_mapping": {"start": 1245, "length": 45, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [30], "starting_column": 9, "ending_column": 54}, "type_specific_fields": {"parent": {"type": "function", "name": "isContract", "source_mapping": {"start": 560, "length": 797, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Address", "source_mapping": {"start": 96, "length": 1709, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44], "starting_column": 1, "ending_column": 2}}, "signature": "isContract(address)"}}}}]}, {"check": "low-level-calls", "impact": "Informational", "confidence": "High", "description": "Low level call in SafeERC20.callOptionalReturn(IERC20,bytes) (contracts/zeppelin/token/ERC20/SafeERC20.sol#55-74):\n\t-(success,returndata) = address(token).call(data) contracts/zeppelin/token/ERC20/SafeERC20.sol#67\n", "elements": [{"type": "function", "name": "callOptionalReturn", "source_mapping": {"start": 2666, "length": 1095, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "SafeERC20", "source_mapping": {"start": 574, "length": 3189, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75], "starting_column": 1, "ending_column": 2}}, "signature": "callOptionalReturn(IERC20,bytes)"}}, {"type": "node", "name": "(success,returndata) = address(token).call(data)", "source_mapping": {"start": 3394, "length": 67, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [67], "starting_column": 9, "ending_column": 76}, "type_specific_fields": {"parent": {"type": "function", "name": "callOptionalReturn", "source_mapping": {"start": 2666, "length": 1095, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "SafeERC20", "source_mapping": {"start": 574, "length": 3189, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_relative": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/token/ERC20/SafeERC20.sol", "filename_short": "contracts/zeppelin/token/ERC20/SafeERC20.sol", "is_dependency": false, "lines": [16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75], "starting_column": 1, "ending_column": 2}}, "signature": "callOptionalReturn(IERC20,bytes)"}}}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_operator' of _operator (contracts/Manager.sol#167) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_operator", "source_mapping": {"start": 6302, "length": 17, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [167], "starting_column": 26, "ending_column": 43}, "type_specific_fields": {"parent": {"type": "function", "name": "setOperator", "source_mapping": {"start": 6281, "length": 147, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [167, 168, 169, 170], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2713, "length": 16246, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 1, "ending_column": 2}}, "signature": "setOperator(address)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_seigniorage' of _seigniorage (contracts/Manager.sol#173) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_seigniorage", "source_mapping": {"start": 6494, "length": 20, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [173], "starting_column": 28, "ending_column": 48}, "type_specific_fields": {"parent": {"type": "function", "name": "setSegniorage", "source_mapping": {"start": 6471, "length": 167, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [173, 174, 175, 176], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2713, "length": 16246, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 1, "ending_column": 2}}, "signature": "setSegniorage(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_delay' of _delay (contracts/Manager.sol#179) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_delay", "source_mapping": {"start": 6703, "length": 14, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [179], "starting_column": 23, "ending_column": 37}, "type_specific_fields": {"parent": {"type": "function", "name": "setDelay", "source_mapping": {"start": 6685, "length": 126, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [179, 180, 181, 182], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Manager", "source_mapping": {"start": 2713, "length": 16246, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_relative": "contracts/Manager.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Manager.sol", "filename_short": "contracts/Manager.sol", "is_dependency": false, "lines": [59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465], "starting_column": 1, "ending_column": 2}}, "signature": "setDelay(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Parameter '_time' of _time (contracts/Proposal.sol#46) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_time", "source_mapping": {"start": 1423, "length": 13, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [46], "starting_column": 21, "ending_column": 34}, "type_specific_fields": {"parent": {"type": "function", "name": "accept", "source_mapping": {"start": 1407, "length": 176, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [46, 47, 48, 49, 50], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Proposal", "source_mapping": {"start": 920, "length": 1585, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_relative": "contracts/Proposal.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/Proposal.sol", "filename_short": "contracts/Proposal.sol", "is_dependency": false, "lines": [28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75], "starting_column": 1, "ending_column": 2}}, "signature": "accept(uint256)"}}}, "additional_fields": {"target": "parameter", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Variable 'Ownable._owner' (contracts/ownership/Ownable.sol#17) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_owner", "source_mapping": {"start": 696, "length": 21, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [17], "starting_column": 5, "ending_column": 26}, "type_specific_fields": {"parent": {"type": "contract", "name": "Ownable", "source_mapping": {"start": 662, "length": 1818, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72], "starting_column": 1, "ending_column": 2}}}, "additional_fields": {"target": "variable", "convention": "mixedCase"}}]}, {"check": "naming-convention", "impact": "Informational", "confidence": "High", "description": "Variable 'Ownable._nominatedOwner' (contracts/ownership/Ownable.sol#18) is not in mixedCase\n", "elements": [{"type": "variable", "name": "_nominatedOwner", "source_mapping": {"start": 723, "length": 30, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [18], "starting_column": 5, "ending_column": 35}, "type_specific_fields": {"parent": {"type": "contract", "name": "Ownable", "source_mapping": {"start": 662, "length": 1818, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_relative": "contracts/ownership/Ownable.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/ownership/Ownable.sol", "filename_short": "contracts/ownership/Ownable.sol", "is_dependency": false, "lines": [16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72], "starting_column": 1, "ending_column": 2}}}, "additional_fields": {"target": "variable", "convention": "mixedCase"}}]}, {"check": "constant-function", "impact": "Medium", "confidence": "Medium", "description": "Address.isContract(address) (contracts/zeppelin/utils/Address.sol#19-32) is declared view but contains assembly code\n", "elements": [{"type": "function", "name": "isContract", "source_mapping": {"start": 560, "length": 797, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32], "starting_column": 5, "ending_column": 6}, "type_specific_fields": {"parent": {"type": "contract", "name": "Address", "source_mapping": {"start": 96, "length": 1709, "filename_used": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_relative": "contracts/zeppelin/utils/Address.sol", "filename_absolute": "/Users/fiddle/reserve/rsv-beta/contracts/zeppelin/utils/Address.sol", "filename_short": "contracts/zeppelin/utils/Address.sol", "is_dependency": false, "lines": [7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44], "starting_column": 1, "ending_column": 2}}, "signature": "isContract(address)"}}], "additional_fields": {"contains_assembly": true}}]