Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Item GST Details after change in GST Accounts #2532

Closed
wants to merge 2 commits into from

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Aug 21, 2024

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (48572d2) to head (e13075e).
Report is 259 commits behind head on develop.

Files with missing lines Patch % Lines
...nce/gst_india/doctype/gst_settings/gst_settings.py 20.00% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2532      +/-   ##
===========================================
+ Coverage    60.26%   61.37%   +1.10%     
===========================================
  Files          119      119              
  Lines        11394    11568     +174     
===========================================
+ Hits          6867     7100     +233     
+ Misses        4527     4468      -59     
Files with missing lines Coverage Δ
...nce/gst_india/doctype/gst_settings/gst_settings.py 71.48% <20.00%> (-5.09%) ⬇️

... and 39 files with indirect coverage changes

Impacted file tree graph

@Sanket322 Sanket322 force-pushed the gst_settings branch 2 times, most recently from 93ee329 to e291de7 Compare August 22, 2024 06:06
function open_patch_schedule_dialog(alert_element) {
const dialog = new frappe.ui.Dialog({
title: __("Schedule Patch Execution Time"),
fields: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message: add documentation link, what details will be updated etc.

@vorasmit
Copy link
Member

  • UX
  • Patch for BOE taxes table

@vorasmit vorasmit closed this Dec 23, 2024

execute_set_gst_tax_type()
execute_update_gst_treatment()
execute_improve_item_tax_template()
Copy link
Member

@vorasmit vorasmit Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bill of entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New workflow for updating Item GST Details and gst tax type automatically on change of GST Accounts.
2 participants