Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle gov api error #2897

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: handle gov api error #2897

wants to merge 4 commits into from
+68 −9

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Dec 20, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (fec611f) to head (d75f40a).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...st_india/doctype/gst_return_log/generate_gstr_1.py 9.09% 10 Missing ⚠️
...gst_india/doctype/gst_return_log/gst_return_log.py 16.66% 5 Missing ⚠️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2897      +/-   ##
===========================================
- Coverage    60.15%   60.07%   -0.08%     
===========================================
  Files          122      122              
  Lines        12061    12080      +19     
===========================================
+ Hits          7255     7257       +2     
- Misses        4806     4823      +17
Files with missing lines Coverage Δ
...gst_india/doctype/gst_return_log/gst_return_log.py 25.00% <16.66%> (-0.47%) ⬇️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <0.00%> (ø)
...st_india/doctype/gst_return_log/generate_gstr_1.py 14.77% <9.09%> (-0.10%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@vorasmit vorasmit linked an issue Dec 23, 2024 that may be closed by this pull request
GSTR-1: Unfiled tab reconciliation could be optional: especially for cases where e-Invoice is not applicable #2881
Open
@vorasmit
Copy link
Member

vorasmit commented Dec 23, 2024 •
edited by Sanket322
Loading

  • Settings for reconciling unfiled data
  • Multiple generate in one all

@ljain112 ljain112 self-assigned this Dec 26, 2024
@ljain112 ljain112 added the p1 label Dec 26, 2024
ljain112
ljain112 reviewed Dec 26, 2024
View reviewed changes
india_compliance/gst_india/doctype/gst_settings/gst_settings.json
"description": "Use API to compare records with GST Portal Before Filing and upload Invoices ",
"fieldname": "compare_for_pre_upload",
"fieldtype": "Check",
"label": "Compare Data with GST Portal and Upload Invoices"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends_on ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljain112 ljain112 ljain112 left review comments

@vorasmit vorasmit vorasmit left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ljain112 ljain112

Labels
p1
Projects
None yet
Milestone
No milestone
3 participants
@Sanket322 @vorasmit @ljain112