Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-submodules is not pulling the requested branch? #470

Closed
jgalan opened this issue Aug 28, 2023 · 3 comments
Closed

pull-submodules is not pulling the requested branch? #470

jgalan opened this issue Aug 28, 2023 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@jgalan
Copy link
Member

jgalan commented Aug 28, 2023

It seems that the pull-submodules.py script is not pulling the corresponding branch for jovoy-mirror_fix, which exists inside https://github.com/rest-for-physics/axionlib/tree/jvonoy-mirror_fix

Instead it seems to be pulling the last commit from the axionlib master branch.

https://github.com/rest-for-physics/framework/actions/runs/6001773909/job/16276684495?pr=469

The pipeline is trying to run the following:

Screenshot 2023-08-28 at 18 16 06

But the commit hash corresponds to axionlib:master

Screenshot 2023-08-28 at 17 38 05

@jgalan jgalan added the invalid This doesn't seem right label Aug 28, 2023
@juanangp juanangp self-assigned this Aug 29, 2023
@juanangp
Copy link
Member

I think that this issue is not related with pull-submodules.py unless you can reproduce the issue locally.

I think that the references to the branches are somehow not properly updated in the validation pipeline, so the jvonoy-mirror-fix branch is not found or outdated.

A work around is to do a push to the jvonoy-mirror-fix branch in axionlib.

There is not an easy fix for this issue, although I think that can be addressed with this PR #405

@juanangp
Copy link
Member

I found the issue, branch names doesn't match, in axionlib is written as jvonoy-mirror_fix while in framework is jovoy-mirror_fix.

@jgalan
Copy link
Member Author

jgalan commented Aug 30, 2023

Ouch! Thats a good reason! Thanks!

I will warn @jovoy

@jgalan jgalan closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants