Border color is distorted with classic mode

[N-R-K]

For testing I was using the following to select a video playing on firefox:

$ ./scrot -s -lmode=classic,width=8,color=#ff3838

When the border was over the playing video, the color was completely distorted. I also noticed this happen when the border was above an xterm window's "selected" region. It was almost as if the border color is being blended with the background color.

edge mode doesn't seem to have this problem.

[daltomi]

edge mode doesn't seem to have this problem.

Yes because edge is a real shaped window, while classic mode is pixel logical operation(GXxor) on root GC (It was always the way scrot worked)

The first draw clears the previous, the second draws.

scrot/src/selection_classic.c

Lines 92 to 95 in d01587d

	if (sel->rect.w)
	selectionClassicDraw();
	selectionCalculateRect(x0, y0, x1, y1);
	selectionClassicDraw();

The possible solution would be to remove the following lines and leave the black and white originally and warn the user that the color is only for edge mode

scrot/src/selection_classic.c

Lines 60 to 64 in d01587d

	XColor color;
	scrotSelectionGetLineColor(&color);
	if (color.pixel != blackColor)
	pc->gcValues.foreground = color.pixel;

Ref: de9e67f ("Allow to change the color to the line style.", 2019-08-19)