diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index c8bc05d79a..da4d64c33c 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -23,7 +23,7 @@ jobs: needs: Get-CI-Image-Tag strategy: matrix: - java: [11, 17] + java: [11, 17, 21] name: Build and Test MLCommons Plugin on linux if: github.repository == 'opensearch-project/ml-commons' @@ -88,7 +88,7 @@ jobs: needs: Build-ml-linux strategy: matrix: - java: [11, 17, 20] + java: [11, 17, 21] name: Test MLCommons Plugin on linux docker if: github.repository == 'opensearch-project/ml-commons' @@ -173,7 +173,7 @@ jobs: Build-ml-windows: strategy: matrix: - java: [11, 17] + java: [11, 17, 21] name: Build and Test MLCommons Plugin on Windows if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env diff --git a/build.gradle b/build.gradle index 151dfc2f6f..68905298f3 100644 --- a/build.gradle +++ b/build.gradle @@ -40,9 +40,9 @@ buildscript { } plugins { - id 'com.netflix.nebula.ospackage' version "11.1.0" + id 'com.netflix.nebula.ospackage' version "11.6.0" id 'java' - id "io.freefair.lombok" version "8.0.1" + id "io.freefair.lombok" version "8.4" id 'jacoco' } diff --git a/client/build.gradle b/client/build.gradle index dbc42522e4..f59df39f99 100644 --- a/client/build.gradle +++ b/client/build.gradle @@ -9,7 +9,7 @@ plugins { id 'jacoco' id 'com.github.johnrengelman.shadow' id 'maven-publish' - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.2' id 'signing' } diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index c1962a79e2..7f93135c49 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 3b37661271..56b2643b27 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -5,7 +5,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip +distributionSha256Sum=3e1af3ae886920c3ac87f7a91f816c0c7c436f276a6eefdb3da152100fef72ae +distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionSha256Sum=5625a0ae20fe000d9225d000b36909c7a0e0e8dda61c19b12da769add847c975 diff --git a/gradlew b/gradlew index aeb74cbb43..1aa94a4269 100755 --- a/gradlew +++ b/gradlew @@ -83,7 +83,8 @@ done # This is normally unused # shellcheck disable=SC2034 APP_BASE_NAME=${0##*/} -APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit +# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036) +APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit # Use the maximum available, or set MAX_FD != -1 to use that value. MAX_FD=maximum @@ -130,10 +131,13 @@ location of your Java installation." fi else JAVACMD=java - which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + if ! command -v java >/dev/null 2>&1 + then + die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the location of your Java installation." + fi fi # Increase the maximum file descriptors if we can. @@ -141,7 +145,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then case $MAX_FD in #( max*) # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC2039,SC3045 MAX_FD=$( ulimit -H -n ) || warn "Could not query maximum file descriptor limit" esac @@ -149,7 +153,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then '' | soft) :;; #( *) # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC2039,SC3045 ulimit -n "$MAX_FD" || warn "Could not set maximum file descriptor limit to $MAX_FD" esac @@ -198,11 +202,11 @@ fi # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' -# Collect all arguments for the java command; -# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of -# shell script including quotes and variable substitutions, so put them in -# double quotes to make sure that they get re-expanded; and -# * put everything else in single quotes, so that it's not re-expanded. +# Collect all arguments for the java command: +# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, +# and any embedded shellness will be escaped. +# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be +# treated as '${Hostname}' itself on the command line. set -- \ "-Dorg.gradle.appname=$APP_BASE_NAME" \ diff --git a/memory/build.gradle b/memory/build.gradle index 1a78e5d153..b49e6227e1 100644 --- a/memory/build.gradle +++ b/memory/build.gradle @@ -20,7 +20,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.2' } dependencies { diff --git a/ml-algorithms/build.gradle b/ml-algorithms/build.gradle index 19b0731212..4c106f88a7 100644 --- a/ml-algorithms/build.gradle +++ b/ml-algorithms/build.gradle @@ -9,7 +9,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.2' } repositories { diff --git a/plugin/build.gradle b/plugin/build.gradle index 1e4e887546..4268506102 100644 --- a/plugin/build.gradle +++ b/plugin/build.gradle @@ -13,7 +13,7 @@ plugins { id "io.freefair.lombok" id 'jacoco' id 'java-library' - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.2' id 'checkstyle' } @@ -35,10 +35,6 @@ checkstyle { toolVersion = '10.12.2' } -lombok { - version = "1.18.28" -} - opensearchplugin { name 'opensearch-ml' description 'machine learning plugin for opensearch' diff --git a/search-processors/build.gradle b/search-processors/build.gradle index 878f46b942..4d30dbe4b2 100644 --- a/search-processors/build.gradle +++ b/search-processors/build.gradle @@ -19,7 +19,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.2' } repositories {