Some failures not reported

[jsfrerot]

We have the following use case when puppet-agent is failing but the exporter doesn't detect/notify the failure.
I think what is missing is to look for the "logs" section and find if there were errors reported by puppet-agent.

Here is a snip of the relevant data:

logs:
- level: err
  message: 'Could not retrieve catalog from remote server: Error 500 on SERVER: Server
    Error: Evaluation Error: Resource type not found: Stdlib::Compat::Ip_address (file:
    /opt/data/puppet_git/modules/squid/manifests/init.pp, line: 178, column: 12) on
    node yul-intproxy-002.ludia.me'
  source: Puppet
  tags:
  - err
  time: '2023-08-16T13:44:54.171960726+00:00'
  file:
  line:

Would it be possible to also check for the log section and return "puppet_last_run_success = 0" when errors are found?

The ressources information are all not reporting any failure:

metrics:
  resources:
    name: resources
    label: Resources
    values:
    - - total
      - Total
      - 579
    - - skipped
      - Skipped
      - 0
    - - failed
      - Failed
      - 0
    - - failed_to_restart
      - Failed to restart
      - 0
    - - restarted
      - Restarted
      - 0
    - - changed
      - Changed
      - 1
    - - out_of_sync
      - Out of sync
      - 1
    - - scheduled
      - Scheduled
      - 0
    - - corrective_change
      - Corrective change
      - 1

and for the ressources:

]# egrep 'resource_statuses|failed:' last_run_report.yaml
resource_statuses:
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false
    failed: false