Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement recursive alias resolution #57

Open
reubeno opened this issue Jun 10, 2024 · 0 comments
Open

implement recursive alias resolution #57

reubeno opened this issue Jun 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@reubeno
Copy link
Owner

reubeno commented Jun 10, 2024

Today, brush has a quick and dirty implementation of alias resolution in interp.rs that works well enough for very simple cases (e.g., alias ll='ls -l'. Per the POSIX spec, alias resolution is supposed to happen after tokenization but before token recognition ("parsing"). It also needs to handle resolving an alias defined in terms of another alias, as well as some cases where subsequent tokens in the command line need to be processed as well.

There's a test case in alias.yaml that currently shows an easy-to-reproduce failure because of missing recursive logic.

@reubeno reubeno added the enhancement New feature or request label Jun 10, 2024
@reubeno reubeno changed the title Properly implement alias resolution implement recursive alias resolution Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant