Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with release due to new revelc parent #143

Open
hazendaz opened this issue Apr 6, 2024 · 1 comment
Open

Issues with release due to new revelc parent #143

hazendaz opened this issue Apr 6, 2024 · 1 comment
Assignees
Labels

Comments

@hazendaz
Copy link
Member

hazendaz commented Apr 6, 2024

Issues have been raised upstream but listing them here for clarity of all that had to change.

  • Not related item first: Javadocs must be produced to release. I'm unclear how we were even releasing this otherwise for last few years without that as that is a very long hard requirement from sonatype. Fixed by adding a Notice dummy class so javadocs get generated.

  • Need to go into m2 cache to revelc-5.pom and hack it a bit otherwise as follows

    • Skip sortpom as its getting confused by LF requirements that conflict with windows user settings (ie myself)
    • Deleted source plugin in release as it is not allowed with newer maven (dual cycles) and tycho does the source plugin and skip didn't seem to turn it off. This was not new as it was already occurring but required hacking the parent here to get it to stop running since it was in middle of release. This could be fixed by adding that back.
    • Skip the formatter plugin as again with LF forcing on windows causes issues with windows user settings (ie myself)

In the build itself...

  • Had to add back all the scm data. That cannot be hidden in a parent. Its not standard and sonatype blocked release. This will need addressed on all the projects this was done with.
@hazendaz hazendaz added the bug label Apr 6, 2024
@hazendaz
Copy link
Member Author

hazendaz commented Apr 6, 2024

One other issue that was a bit unrelated. All revelc uses a legacy setup in maven server settings.xml for ossrh which results in exposure of 2 locations for account data. The server id should be changed. While I could have hacked that in the parent, I had the old data in a to delete old settings file so I simply restored it and marked why it was still used.

@hazendaz hazendaz self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant