Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please add a license for this project #193

Open
daqingshu opened this issue May 29, 2020 · 4 comments
Open

Could you please add a license for this project #193

daqingshu opened this issue May 29, 2020 · 4 comments

Comments

@daqingshu
Copy link

thanks a lot

@dotcs
Copy link

dotcs commented Mar 16, 2021

I agree.

Please follow the links to learn more about how to add a license to a repository, which licenses are available and why you should do so.

Thank you very much in advance for adding a license to your project.

@MichielDeMey
Copy link

This module is licenced under MIT since Feb 1 2015 as stated in the package.json file: https://github.com/reworkcss/rework/blob/master/package.json#L32

However, this change has never been published to NPM so license scanners might not pick this up.
I'm not a lawyer, so consult a professional to interpret the legal implications of this.

To be on the safe side, you can always fork from master and re-publish yourself.

@dotcs
Copy link

dotcs commented Jun 3, 2021

Thanks @MichielDeMey for pointing this out. The main problem with not publishing the license information to NPM is that automatic license checkers probably mark this package as problematic. Indeed in my company this happened which is why I added my comment above.
As other packages might depend on this one, so a simple fork and re-publish won't help in those cases. Since the package has been licensed in Feb 2015 the license checker will only yield a false positive here, but still I guess it would be better to fix the root cause of this problem. Otherwise some companies might reject not only this package but also the ones that rely on it in their dependency graphs.

@dakotahp
Copy link

dakotahp commented Aug 6, 2021

Another vote for adding the license correctly. This is now wasting 15-20min of my day to manually excuse this dependency because license scanners that my organization don't pick it up easier. If it ain't on https://www.npmjs.com/package/rework then it is unlicensed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants